Skip to content

remove duplicates from test_ids array #21347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eleanor Boyd (eleanorjboyd) merged 1 commit into from
May 31, 2023
Merged

remove duplicates from test_ids array #21347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove duplicates from test_ids array
  • Loading branch information
eleanorjboyd
eleanorjboyd committed May 31, 2023
commit 2fe9bb01b8d63f314a6908de02392a1c98691faa
6 changes: 3 additions & 3 deletions src/client/testing/testController/workspaceTestAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class WorkspaceTestAdapter {

let rawTestExecData;
const testCaseNodes: TestItem[] = [];
const testCaseIds: string[] = [];
const testCaseIdsSet = new Set<string>();
try {
// first fetch all the individual test Items that we necessarily want
includes.forEach((t) => {
Expand All @@ -95,10 +95,10 @@ export class WorkspaceTestAdapter {
runInstance.started(node); // do the vscode ui test item start here before runtest
const runId = this.vsIdToRunId.get(node.id);
if (runId) {
testCaseIds.push(runId);
testCaseIdsSet.add(runId);
}
});

const testCaseIds = Array.from(testCaseIdsSet);
// ** execution factory only defined for new rewrite way
if (executionFactory !== undefined) {
rawTestExecData = await this.executionAdapter.runTests(
Expand Down