Skip to content

fix debugging with new pytest run script #21299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eleanor Boyd (eleanorjboyd) merged 3 commits into from
May 25, 2023
Merged

fix debugging with new pytest run script #21299

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfc39b5
fix debugging with new pytest run script
May 25, 2023
7ffe3ef
fixing console log
May 25, 2023
e29f6ef
fix trace types
May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing console log
  • Loading branch information
eleanorjboyd
eleanorjboyd committed May 25, 2023
commit 7ffe3efeb8c9ec80ae1e57938882194730b0c9ea
8 changes: 4 additions & 4 deletions src/client/testing/testController/pytest/pytestExecutionAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ export class PytestTestExecutionAdapter implements ITestExecutionAdapter {
spawnOptions.extraVariables.RUN_TEST_IDS_PORT = pytestRunTestIdsPort;
})
.catch((error) => {
console.error('Error starting server:', error);
traceVerbose('Error starting server:', error);
Comment thread
eleanorjboyd marked this conversation as resolved.
Outdated
});

if (debugBool) {
Expand All @@ -169,20 +169,20 @@ export class PytestTestExecutionAdapter implements ITestExecutionAdapter {
pytestUUID,
pytestRunTestIdsPort,
};
console.debug(`Running debug test with arguments: ${testArgs.join(' ')}\r\n`);
traceVerbose(`Running debug test with arguments: ${testArgs.join(' ')}\r\n`);
await debugLauncher!.launchDebugger(launchOptions);
} else {
// combine path to run script with run args
const scriptPath = path.join(fullPluginPath, 'vscode_pytest', 'run_pytest_script.py');
const runArgs = [scriptPath, ...testArgs];

await execService?.exec(runArgs, spawnOptions).catch((ex) => {
console.debug(`Error while running tests: ${testIds}\r\n${ex}\r\n\r\n`);
traceVerbose(`Error while running tests: ${testIds}\r\n${ex}\r\n\r\n`);
return Promise.reject(ex);
});
}
} catch (ex) {
console.debug(`Error while running tests: ${testIds}\r\n${ex}\r\n\r\n`);
traceVerbose(`Error while running tests: ${testIds}\r\n${ex}\r\n\r\n`);
return Promise.reject(ex);
}

Expand Down