Skip to content

Localize strings on github.dev using VSCode FS API #17711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kartik Raj (karrtikr) merged 10 commits into from
Oct 13, 2021
Merged

Localize strings on github.dev using VSCode FS API #17711

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
74c7613
Change localization in the extension to be async and use the VS Code …
Oct 12, 2021
776bb16
News entry
Oct 12, 2021
965bc56
Modify error thrown
Oct 12, 2021
476ede7
Move localization into separate module
Oct 12, 2021
a6a7340
Update news entry
Oct 12, 2021
b6b171d
Oops
Oct 12, 2021
40fa419
Refactor so code is not duplicated
Oct 13, 2021
26c4892
Fix tests
Oct 13, 2021
5543553
Oopsp
Oct 13, 2021
224f549
Fix lint
Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix lint
  • Loading branch information
Kartik Raj
Kartik Raj committed Oct 13, 2021
commit 224f549def33d96b9b50a142f691c669b4d276b1
2 changes: 1 addition & 1 deletion src/client/common/utils/localizeHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function parseLocale(): string {
return vscodeConfigString ? JSON.parse(vscodeConfigString).locale : 'en-us';
}

export function getLocalizedString(key: string, defValue?: string) {
export function getLocalizedString(key: string, defValue?: string): string {
// The default collection (package.nls.json) is the fallback.
// Note that we are guaranteed the following (during shipping)
// 1. defaultCollection was initialized by the load() call above
Expand Down