Skip to content

Ensure commands run are not logged twice in Python output channel #17697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kartik Raj (karrtikr) merged 2 commits into from
Oct 11, 2021
Merged

Ensure commands run are not logged twice in Python output channel #17697

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da188b0
Ensure commands run are not logged twice in Python output channel
Oct 11, 2021
8e32caf
News entry
Oct 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Ensure commands run are not logged twice in Python output channel
  • Loading branch information
Kartik Raj
Kartik Raj committed Oct 11, 2021
commit da188b0c258554016fa1aa63cc5968174df3e4e3
1 change: 0 additions & 1 deletion src/client/common/process/pythonExecutionFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ export class PythonExecutionFactory implements IPythonExecutionFactory {
pythonPath = this.configService.getSettings(options.resource).pythonPath;
}
const processService: IProcessService = await this.processServiceFactory.create(options.resource);
processService.on('exec', this.logger.logProcess.bind(this.logger));

const windowsStoreInterpreterCheck = (await inDiscoveryExperiment(this.experimentService))
? // Class methods may depend on other properties which belong to the class, so bind the correct context.
Expand Down