Skip to content

Revert linter installation prompt removal #16147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kim-Adeline Miguel (kimadeline) merged 4 commits into from
May 5, 2021
Merged

Revert linter installation prompt removal #16147

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
447cf67
Re-add prompt to install a linter
May 5, 2021
c1026bf
News entry
May 5, 2021
c9d76c2
Remove experiment group
May 5, 2021
8ab1a4c
Remove leftover experiments telemetry
May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove leftover experiments telemetry
  • Loading branch information
Kim-Adeline Miguel
Kim-Adeline Miguel committed May 5, 2021
commit 8ab1a4c6e6f42b3cdb917d6e6d063450997e8f69
1 change: 0 additions & 1 deletion src/client/telemetry/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ export enum EventName {

LINTER_NOT_INSTALLED_PROMPT = 'LINTER_NOT_INSTALLED_PROMPT',
LINTER_INSTALL_PROMPT = 'LINTER_INSTALL_PROMPT',
LINTER_INSTALL_PROMPT_ACTION = 'LINTER_INSTALL_PROMPT_ACTION',
CONFIGURE_AVAILABLE_LINTER_PROMPT = 'CONFIGURE_AVAILABLE_LINTER_PROMPT',
HASHED_PACKAGE_NAME = 'HASHED_PACKAGE_NAME',
HASHED_PACKAGE_PERF = 'HASHED_PACKAGE_PERF',
Expand Down
19 changes: 0 additions & 19 deletions src/client/telemetry/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,25 +830,6 @@ export interface IEventNamePropertyMapping {
prompt: 'old' | 'noPrompt' | 'pylintFirst' | 'flake8first';
};

/**
* Telemetry event sent after user had selected one of the options
* provided by the linter prompt.
*/
[EventName.LINTER_INSTALL_PROMPT_ACTION]: {
/**
* Identify which prompt was shown.
*
* @type {('pylintFirst' | 'flake8first')}
*/
prompt: 'pylintFirst' | 'flake8first';

/**
* Which of the following actions did user select
*
* @type {('pylint' | 'flake8' | 'disablePrompt' | 'close')}
*/
action: 'installPylint' | 'installFlake8' | 'disablePrompt' | 'close';
};
/**
* Telemetry event sent when installing modules
*/
Expand Down