Create a new API to retrieve interpreter details with the ability to cache the details - #1567
Merged
Don Jayamanne (DonJayamanne) merged 8 commits intoMay 10, 2018
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1567 +/- ##
=========================================
Coverage ? 71.42%
=========================================
Files ? 277
Lines ? 12983
Branches ? 2334
=========================================
Hits ? 9273
Misses ? 3574
Partials ? 136
Continue to review full report at Codecov.
|
Member
|
That's quite the title 😉 |
Author
|
Didn't want anyone to waste time reviewing the PR. However I wanted the This PR is something I was working on during my free time (was getting too tired with debugger). Related to #1351 (laying the ground work for that and a couple of other parts of the extension). |
Don Jayamanne (DonJayamanne)
force-pushed
the
issue1351InterpreterDisplay
branch
from
May 4, 2018 23:23
fca4cf0 to
90ee001
Compare
Don Jayamanne (DonJayamanne)
changed the title
Author
|
@Microsoft/pvsc-team This PR is ready for review. |
Don Jayamanne (DonJayamanne)
force-pushed
the
issue1351InterpreterDisplay
branch
from
May 8, 2018 22:26
946e3aa to
4a6581a
Compare
Don Jayamanne (DonJayamanne)
force-pushed
the
issue1351InterpreterDisplay
branch
from
May 9, 2018 02:21
4a6581a to
9c35848
Compare
Mikhail Arkhipov (MikhailArkhipov)
approved these changes
May 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1569
Partial work for #1351
This PR introduced about to get interpreter info and cache it. The information built will be used to build the display name and used in analysis engine (separate PR).
So, this PR focuses on being backwards compatible.
This pull request: