Skip to content

Remove prompt to install a linter #15646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kim-Adeline Miguel (kimadeline) merged 6 commits into from
Mar 18, 2021
Merged

Remove prompt to install a linter #15646

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1cedb1d
Remove prompt to install a linter
Mar 11, 2021
121e825
Forgot to remove the experiment group lol
Mar 11, 2021
1c778d9
Skip installing linter in single-workspace tests
Mar 12, 2021
c7e2f17
Forgot the other test lol
Mar 12, 2021
d37e19f
Merge branch 'main' into 15465-drop-pylint-notification
Mar 12, 2021
947a46a
Merge branch 'main' into 15465-drop-pylint-notification
Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Forgot the other test lol
  • Loading branch information
Kim-Adeline Miguel
Kim-Adeline Miguel committed Mar 12, 2021
commit c7e2f171eb4bac8e2e73f65f9e65803d38ce7077
4 changes: 3 additions & 1 deletion src/test/common/installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,9 +323,11 @@ suite('Installer', () => {
}
getNamesAndValues<Product>(Product).forEach((prod) => {
test(`Ensure isInstalled for Product: '${prod.name}' executes the right command`, async function () {
if (new ProductService().getProductType(prod.value) === ProductType.DataScience) {
const productType = new ProductService().getProductType(prod.value);
if (productType === ProductType.DataScience || productType === ProductType.Linter) {
return this.skip();
}

ioc.serviceManager.addSingletonInstance<IModuleInstaller>(
IModuleInstaller,
new MockModuleInstaller('one', false),
Expand Down