Skip to content

Show Python: Launch TensorBoard command in command palette #15382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joyce Er (joyceerhl) merged 4 commits into from
Feb 11, 2021
Merged

Show Python: Launch TensorBoard command in command palette #15382

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d971bae
Always register Launch TensorBoard command
joyceerhl Feb 11, 2021
d90a6fa
Put usage tracking behind experiment
joyceerhl Feb 11, 2021
4475385
Linter
joyceerhl Feb 11, 2021
230f7c8
Fix test
joyceerhl Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Put usage tracking behind experiment
  • Loading branch information
@joyceerhl
joyceerhl committed Feb 11, 2021
commit d90a6fad42f2d2b7321e6ce035c962db8fa5a26b
7 changes: 6 additions & 1 deletion src/client/tensorBoard/tensorBoardUsageTracker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import { TextEditor } from 'vscode';
import { IExtensionSingleActivationService } from '../activation/types';
import { IDocumentManager } from '../common/application/types';
import { isTestExecution } from '../common/constants';
import { IDisposableRegistry } from '../common/types';
import { NativeTensorBoard } from '../common/experiments/groups';
import { IDisposableRegistry, IExperimentService } from '../common/types';
import { getDocumentLines } from '../telemetry/importTracker';
import { TensorBoardEntrypointTrigger } from './constants';
import { containsTensorBoardImport } from './helpers';
Expand All @@ -23,9 +24,13 @@ export class TensorBoardUsageTracker implements IExtensionSingleActivationServic
@inject(IDocumentManager) private documentManager: IDocumentManager,
@inject(IDisposableRegistry) private disposables: IDisposableRegistry,
@inject(TensorBoardPrompt) private prompt: TensorBoardPrompt,
@inject(IExperimentService) private experimentService: IExperimentService,
) {}

public async activate(): Promise<void> {
if (!(await this.experimentService.inExperiment(NativeTensorBoard.experiment))) {
return;
}
if (testExecution) {
await this.activateInternal();
} else {
Expand Down
13 changes: 12 additions & 1 deletion src/test/tensorBoard/tensorBoardUsageTracker.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,29 @@ import { TensorBoardUsageTracker } from '../../client/tensorBoard/tensorBoardUsa
import { TensorBoardPrompt } from '../../client/tensorBoard/tensorBoardPrompt';
import { MockDocumentManager } from '../startPage/mockDocumentManager';
import { createTensorBoardPromptWithMocks } from './helpers';
import { mock, when, instance } from 'ts-mockito';
import { NativeTensorBoard } from '../../client/common/experiments/groups';
import { ExperimentService } from '../../client/common/experiments/service';

suite('TensorBoard usage tracker', () => {
let documentManager: MockDocumentManager;
let tensorBoardImportTracker: TensorBoardUsageTracker;
let prompt: TensorBoardPrompt;
let experimentService: ExperimentService;
let showNativeTensorBoardPrompt: sinon.SinonSpy;

setup(() => {
documentManager = new MockDocumentManager();
prompt = createTensorBoardPromptWithMocks();
showNativeTensorBoardPrompt = sinon.spy(prompt, 'showNativeTensorBoardPrompt');
tensorBoardImportTracker = new TensorBoardUsageTracker(documentManager, [], prompt);
experimentService = mock(ExperimentService);
when(experimentService.inExperiment(NativeTensorBoard.experiment)).thenResolve(true);
tensorBoardImportTracker = new TensorBoardUsageTracker(
documentManager,
[],
prompt,
instance(experimentService),
);
});

test('Simple tensorboard import in Python file', async () => {
Expand Down