Skip to content

Added FSWatching base class and made related changes #14605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kartik Raj (karrtikr) merged 10 commits into from
Nov 6, 2020
Merged

Added FSWatching base class and made related changes #14605

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ad675c1
Add FSWatching locator base class
Nov 4, 2020
06e6f5b
Correct glob pattern to not match python3.2whoa
Nov 4, 2020
c167f57
Add documentation of python binary watcher
Nov 4, 2020
375df6b
Fix lint errors
Nov 4, 2020
3ef70e3
Update ignore list
Nov 4, 2020
5925ab1
Add disposable registry
Nov 5, 2020
31f7c54
Modify FSWatching Locator
Nov 5, 2020
fec8c1b
Code reviews
Nov 5, 2020
21b740a
Use string[]
Nov 5, 2020
2260b17
Remove list disposable getter
Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove list disposable getter
  • Loading branch information
Kartik Raj
Kartik Raj committed Nov 5, 2020
commit 2260b176ced0639d4727e64bec0a00b50388d8b3
4 changes: 0 additions & 4 deletions src/client/common/syncDisposableRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,4 @@ export class DisposableRegistry implements IDisposable {
this._list.push(disposable);
}
}

public get list(): IDisposable[] {
return this._list;
}
}