Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2aac150
Splitting test log
rchiodo Oct 7, 2020
bcd65e9
Fix problem with kernels ports being reused
rchiodo Oct 8, 2020
a908fe1
Make kernel launcher port round robin only for testing
rchiodo Oct 8, 2020
629e881
Make formatters change only apply during testing
rchiodo Oct 8, 2020
e64ff0b
Add news entry
rchiodo Oct 8, 2020
30aaacd
Apply black formatting
rchiodo Oct 8, 2020
cd0fe62
Code review feedback and skip flakey remote password test
rchiodo Oct 8, 2020
d4e19f7
Another flakey test
rchiodo Oct 8, 2020
56076da
More CR feedback
rchiodo Oct 8, 2020
688fb58
Missed a spot
rchiodo Oct 8, 2020
64ff3ef
Merge remote-tracking branch 'origin/main' into rchiodo/more_flake_fa…
rchiodo Oct 9, 2020
e922c10
Some more log parser changes and try to get interrupt to be less flakey
rchiodo Oct 9, 2020
47b34a9
Fix interrupt killing kernel and add more logging for export
rchiodo Oct 9, 2020
24ef1ef
More logging
rchiodo Oct 9, 2020
908f7b0
See if updating fixes the problem
rchiodo Oct 9, 2020
7b78058
Dont delete temp files
rchiodo Oct 9, 2020
2095505
Upload webview output to figure out trust failure
rchiodo Oct 9, 2020
1177f3e
Add name to step
rchiodo Oct 9, 2020
58e2469
Merge remote-tracking branch 'origin/main' into rchiodo/more_flake_fa…
rchiodo Oct 9, 2020
3763991
Try another way to upload
rchiodo Oct 9, 2020
c6a08e7
Upload doesn't seem to work
rchiodo Oct 9, 2020
3043960
Try a different way to upload
rchiodo Oct 9, 2020
97183b9
Try without webview logging as this makes the test pass
rchiodo Oct 9, 2020
2c3decc
Try fixing test another way. Any logging is making the test pass
rchiodo Oct 9, 2020
f1765f9
Compile error
rchiodo Oct 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some more log parser changes and try to get interrupt to be less flakey
  • Loading branch information
rchiodo committed Oct 9, 2020
commit e922c1057e409c9da8b9fbfd86b492867bc50639
5 changes: 3 additions & 2 deletions build/ci/scripts/runFunctionalTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,13 @@ async function generateGroups(files) {

async function runIndividualTest(extraArgs, file, index) {
var subMochaFile = `${mochaBaseFile}_${index}_${path.basename(file)}${mochaFileExt}`;
process.env['MOCHA_FILE'] = subMochaFile;
var args = gatherArgs(extraArgs, file);
console.log(`Running functional test for file ${file} ...`);
var exitCode = await new Promise((resolve) => {
// Spawn the sub node process
var proc = child_process.fork('./node_modules/mocha/bin/_mocha', args);
var proc = child_process.fork('./node_modules/mocha/bin/_mocha', args, {
env: { ...process.env, MOCHA_FILE: subMochaFile }
});
proc.on('exit', resolve);
});

Expand Down
14 changes: 12 additions & 2 deletions pythonFiles/vscode_datascience_helpers/tests/logParser.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from io import TextIOWrapper
import sys
import argparse
import os
Expand All @@ -18,13 +19,22 @@
)
ansi_escape = re.compile(r"\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])")
pid_regex = re.compile(r"(\d+).*")
timestamp_regex = re.compile(r"\d{4}-\d{2}-\d{2}T.*\dZ")

def stripTimestamp(line: str):
match = timestamp_regex.match(line)
if (match):
return line[match.endpos]
return line

def readStripLines(f: TextIOWrapper):
return map(f.readlines(), stripTimestamp)

def printTestOutput(testlog):
# Find all the lines that don't have a PID in them. These are the test output
p = Path(testlog[0])
with p.open() as f:
for line in f.readlines():
for line in readStripLines(f):
stripped = line.strip()
if len(stripped) > 2 and stripped[0] == "\x1B" and stripped[1] == "[":
print(line.rstrip()) # Should be a test line as it has color encoding
Expand All @@ -38,7 +48,7 @@ def splitByPid(testlog):
logs = {}
pid = None
with p.open() as f:
for line in f.readlines():
for line in readStripLines(f):
stripped = ansi_escape.sub("", line.strip())
# See if starts with a pid
if len(stripped) > 0 and stripped[0] <= "9" and stripped[0] >= "0":
Expand Down
8 changes: 7 additions & 1 deletion src/test/datascience/raw-kernel/rawKernel.functional.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,13 @@ suite('DataScience raw kernel tests', () => {
// Hence timeout is a test failure.
const longCellExecutionRequest = requestExecute(
rawKernel,
'import time\nfor i in range(300):\n time.sleep(1)',
`import time
import sys
for i in range(3000):
sys.stdout.write('.')
sys.stdout.flush()
time.sleep(0.1)
sys.stdout.write('\r')`,
executionStarted
);

Expand Down