Skip to content

Fix sample notebook to state that you can double click to edit a cell - #14238

Merged
Joyce Er (joyceerhl) merged 3 commits into
mainfrom
joyceerhl/ipynb
Oct 2, 2020
Merged

Joyce Er (joyceerhl) merged 3 commits into
mainfrom
joyceerhl/ipynb

Conversation

@joyceerhl

@joyceerhl Joyce Er (joyceerhl) commented Oct 2, 2020 •

Copy link
Copy Markdown

Closes https://github.com/microsoft/vscode-python/issues/14112

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Oct 2, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #14238 into main will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #14238   +/-   ##
=======================================
  Coverage   59.95%   59.95%           
=======================================
  Files         706      706           
  Lines       39183    39181    -2     
  Branches     5681     5681           
=======================================
- Hits        23493    23492    -1     
+ Misses      14453    14452    -1     
  Partials     1237     1237           
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 68.00% <0.00%> (-4.00%) ⬇️
src/client/datascience/notebook/helpers/helpers.ts 37.29% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bf9c5...59b31bb. Read the comment docs.

"You are currently viewing what we call our Notebook Editor. It is an interactive document based on Jupyter Notebooks that supports the intermixing of code, outputs and markdown documentation. \n",
"\n",
"This cell is a markdown cell. To edit the text in this cell, simply click on the cell to change it into edit mode.\n",
"This cell is a markdown cell. To edit the text in this cell, simply double click on the cell to change it into edit mode.\n",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR actually made me look up if there was supposed to be a hyphen here or not. The internet seems a bit unsure, so I vote we go ahead with this.

@sonarqubecloud

sonarqubecloud Bot commented Oct 2, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@joyceerhl
Joyce Er (joyceerhl) merged commit ef44f29 into main Oct 2, 2020
@joyceerhl
Joyce Er (joyceerhl) deleted the joyceerhl/ipynb branch October 2, 2020 23:51
Don Jayamanne (DonJayamanne) pushed a commit that referenced this pull request Oct 30, 2020
…-jupyter (#194)

* Fix sample notebook to state that you can double click to edit a cell (#14238)

* Disable surveys if running in codespaces (#14332)

* Disable surveys if running in codespaces

* Disable gather survey in codespaces too

* For gather, show a description without the survey

* Fixes for IW tests where UIKind is not defined

* Fix all the tests where UIKind is not defined

* Appease hygiene

* Disable mailing list if running in Codespaces (#14347)

* Show tensor dimensions in variable explorer (#14244)

* Fix markdown cell marker formatting for export to Python (#14360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample notebook incorrectly states that you can edit a cell by clicking on it (editing requires double click)

6 participants