Skip to content

Escaping fix broke a number of things #14145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich Chiodo (rchiodo) merged 5 commits into from
Sep 29, 2020
Merged

Escaping fix broke a number of things #14145

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8211a9
Fixes for escaping
rchiodo Sep 28, 2020
371ac9e
Push a comment ot start PR again
rchiodo Sep 28, 2020
c6543d6
Cache task is failing
rchiodo Sep 28, 2020
eca474c
Remove cache task
rchiodo Sep 28, 2020
8b06e3c
Not fixing so just put back cache task
rchiodo Sep 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Push a comment ot start PR again
  • Loading branch information
@rchiodo
rchiodo committed Sep 28, 2020
commit 371ac9e56214213e913b0514ba6649c46edbee50
2 changes: 2 additions & 0 deletions src/client/datascience/jupyter/jupyterDebugger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,8 @@ export class JupyterDebugger implements IJupyterDebugger, ICellHashListener {
if (outputs.length > 0) {
const data = outputs[0].data;
if (data && data.hasOwnProperty('text/plain')) {
// Plain text should be escaped by our execution engine. Unescape it so
// we can parse it.
// tslint:disable-next-line:no-any
return unescape((data as any)['text/plain']);
}
Expand Down