Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
2b02bfc
Add a basic implementation of CachingLocator.
ericsnowcurrently Sep 21, 2020
8fa4647
Add a noop envs cache implementation.
ericsnowcurrently Sep 23, 2020
f7efae8
Use CachingLocator.
ericsnowcurrently Sep 21, 2020
33b63ba
Adjust PythonEnvInfoCache for use as a testing fake.
ericsnowcurrently Oct 5, 2020
8220cea
Replace usage of EmptyCache with PythonEnvInfoCache.
ericsnowcurrently Oct 5, 2020
7350eb2
Make CachingLocator.initialize() idempotent.
ericsnowcurrently Sep 29, 2020
c328bd6
Move the onChanged hook to initialize().
ericsnowcurrently Sep 29, 2020
0a442e3
Pass the change event through to refresh().
ericsnowcurrently Sep 29, 2020
8642594
Do not inherit from PythonEnvsWatcher.
ericsnowcurrently Sep 29, 2020
e778d73
Add CachingLocator.dispose().
ericsnowcurrently Sep 29, 2020
0c6925a
Factor out initialRefresh().
ericsnowcurrently Sep 29, 2020
a973035
Add BackgroundLooper.
ericsnowcurrently Sep 30, 2020
b87ec6b
Only run a single refresh operation at a time.
ericsnowcurrently Sep 30, 2020
bf39d81
Simplify BackgroundLooper.
ericsnowcurrently Sep 30, 2020
5ad921d
Add support for retries.
ericsnowcurrently Sep 30, 2020
4a22fec
Eliminate the queue stability issues with getID().
ericsnowcurrently Sep 30, 2020
8a561e0
Fix the logic of the run loop.
ericsnowcurrently Sep 30, 2020
6038238
Periodically refresh the cache.
ericsnowcurrently Sep 30, 2020
72becf8
Rely on onChanged to know if the cache is stale.
ericsnowcurrently Sep 30, 2020
764482a
Add BackgroundLooper.getNextRequest().
ericsnowcurrently Sep 30, 2020
1a71c49
Factor out CachingLocator.iterFromDownstream().
ericsnowcurrently Sep 30, 2020
99af470
Fix the tslint rules.
ericsnowcurrently Sep 30, 2020
e31ee15
Fix callbacks in SimpleLocator.
ericsnowcurrently Oct 5, 2020
d73de35
Fix a typo.
ericsnowcurrently Oct 5, 2020
c26b56c
Use a syntactic shortcut.
ericsnowcurrently Oct 5, 2020
e756686
Add doc comments on internal methods.
ericsnowcurrently Oct 5, 2020
316dd91
Make the different refresh scenarios a bit easier to follow.
ericsnowcurrently Oct 5, 2020
c1ee05b
Add doc comments for BackgroundLooper.
ericsnowcurrently Oct 5, 2020
d666874
Clarify a comment about popping the next request off the queue.
ericsnowcurrently Oct 5, 2020
b091801
Drop the retry/periodic code.
ericsnowcurrently Sep 30, 2020
0c90c6f
Fix typos.
ericsnowcurrently Oct 7, 2020
6bc3b00
Drop unnecessary eslint directives.
ericsnowcurrently Oct 7, 2020
89b6e5e
Move BackgroundRequestLooper to its own file.
ericsnowcurrently Oct 7, 2020
5fd0141
Drop a dead comment.
ericsnowcurrently Oct 7, 2020
68a618f
downstream -> wrapped
ericsnowcurrently Oct 7, 2020
adacb7c
refresh() -> addRefreshRequest()
ericsnowcurrently Oct 7, 2020
e8914f6
Clarify a potentially confusing situation in getGlobalPersistentStore().
ericsnowcurrently Oct 7, 2020
134915b
Use a more concise syntax.
ericsnowcurrently Oct 7, 2020
fa63318
lint
ericsnowcurrently Oct 8, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify a potentially confusing situation in getGlobalPersistentStore().
  • Loading branch information
ericsnowcurrently committed Oct 7, 2020
commit e8914f6d9968653d519269511f60e960534cf2d0
5 changes: 5 additions & 0 deletions src/test/pythonEnvironments/base/envsCache.unit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ suite('Environment Info cache', () => {
});

function getGlobalPersistentStore() {
// It may look like we are making this call directly, but note
// that in `setup()` we have already stubbed the function out.
// We take this approach so the tests more closely match how
// `PythonEnvInfoCache` will actually be used in the VS Code
// extension.
const store = externalDependencies.getGlobalPersistentStore<PythonEnvInfo[]>('PYTHON_ENV_INFO_CACHE');
Comment thread
ericsnowcurrently marked this conversation as resolved.
Resolved
return {
load: async () => store.get(),
Expand Down