Repository navigation
Add CachingLocator. #14020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Eric Snow (ericsnowcurrently)
merged 39 commits into
microsoft:main
from
ericsnowcurrently:pyenvs-component-caching-locator
Oct 8, 2020
Merged
Add CachingLocator. #14020
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
2b02bfc
Add a basic implementation of CachingLocator.
ericsnowcurrently 8fa4647
Add a noop envs cache implementation.
ericsnowcurrently f7efae8
Use CachingLocator.
ericsnowcurrently 33b63ba
Adjust PythonEnvInfoCache for use as a testing fake.
ericsnowcurrently 8220cea
Replace usage of EmptyCache with PythonEnvInfoCache.
ericsnowcurrently 7350eb2
Make CachingLocator.initialize() idempotent.
ericsnowcurrently c328bd6
Move the onChanged hook to initialize().
ericsnowcurrently 0a442e3
Pass the change event through to refresh().
ericsnowcurrently 8642594
Do not inherit from PythonEnvsWatcher.
ericsnowcurrently e778d73
Add CachingLocator.dispose().
ericsnowcurrently 0c6925a
Factor out initialRefresh().
ericsnowcurrently a973035
Add BackgroundLooper.
ericsnowcurrently b87ec6b
Only run a single refresh operation at a time.
ericsnowcurrently bf39d81
Simplify BackgroundLooper.
ericsnowcurrently 5ad921d
Add support for retries.
ericsnowcurrently 4a22fec
Eliminate the queue stability issues with getID().
ericsnowcurrently 8a561e0
Fix the logic of the run loop.
ericsnowcurrently 6038238
Periodically refresh the cache.
ericsnowcurrently 72becf8
Rely on onChanged to know if the cache is stale.
ericsnowcurrently 764482a
Add BackgroundLooper.getNextRequest().
ericsnowcurrently 1a71c49
Factor out CachingLocator.iterFromDownstream().
ericsnowcurrently 99af470
Fix the tslint rules.
ericsnowcurrently e31ee15
Fix callbacks in SimpleLocator.
ericsnowcurrently d73de35
Fix a typo.
ericsnowcurrently c26b56c
Use a syntactic shortcut.
ericsnowcurrently e756686
Add doc comments on internal methods.
ericsnowcurrently 316dd91
Make the different refresh scenarios a bit easier to follow.
ericsnowcurrently c1ee05b
Add doc comments for BackgroundLooper.
ericsnowcurrently d666874
Clarify a comment about popping the next request off the queue.
ericsnowcurrently b091801
Drop the retry/periodic code.
ericsnowcurrently 0c90c6f
Fix typos.
ericsnowcurrently 6bc3b00
Drop unnecessary eslint directives.
ericsnowcurrently 89b6e5e
Move BackgroundRequestLooper to its own file.
ericsnowcurrently 5fd0141
Drop a dead comment.
ericsnowcurrently 68a618f
downstream -> wrapped
ericsnowcurrently adacb7c
refresh() -> addRefreshRequest()
ericsnowcurrently e8914f6
Clarify a potentially confusing situation in getGlobalPersistentStore().
ericsnowcurrently 134915b
Use a more concise syntax.
ericsnowcurrently fa63318
lint
ericsnowcurrently File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Clarify a potentially confusing situation in getGlobalPersistentStore().
- Loading branch information
commit e8914f6d9968653d519269511f60e960534cf2d0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.