Skip to content

Extension API to return path to debugpy for DS #13973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Don Jayamanne (DonJayamanne) merged 4 commits into from
Sep 17, 2020
Merged

Extension API to return path to debugpy for DS #13973

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
439f11b
Debugger API for DS
DonJayamanne Sep 17, 2020
374f329
Oops
DonJayamanne Sep 17, 2020
fa136f4
OOps
DonJayamanne Sep 17, 2020
d34c91b
Code review changes
DonJayamanne Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/client/datascience/api/jupyterIntegration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@
// Licensed under the MIT License.

import { inject, injectable } from 'inversify';
import { join } from 'path';
import { CancellationToken, Event, Uri } from 'vscode';
import { InterpreterUri } from '../../common/installer/types';
import { IExtensions, IInstaller, InstallerResponse, Product, Resource } from '../../common/types';
import { EXTENSION_ROOT_DIR } from '../../constants';
import { IEnvironmentActivationService } from '../../interpreter/activation/types';
import { IInterpreterQuickPickItem, IInterpreterSelector } from '../../interpreter/configuration/types';
import { IInterpreterService } from '../../interpreter/contracts';
Expand Down Expand Up @@ -51,6 +53,10 @@ type PythonApiForJupyterExtension = {
* IInstaller
*/
install(product: Product, resource?: InterpreterUri, cancel?: CancellationToken): Promise<InstallerResponse>;
/**
* Returns path to where `debugpy` is. In python extension this is `/pythonFiles/lib/python`.
*/
getDebuggerPath(): Promise<string>;
};

type JupyterExtensionApi = {
Expand Down Expand Up @@ -97,7 +103,8 @@ export class JupyterExtensionIntegration {
product: Product,
resource?: InterpreterUri,
cancel?: CancellationToken
): Promise<InstallerResponse> => this.installer.install(product, resource, cancel)
): Promise<InstallerResponse> => this.installer.install(product, resource, cancel),
getDebuggerPath: async () => join(EXTENSION_ROOT_DIR, 'pythonFiles', 'lib', 'python')
Comment thread
DonJayamanne marked this conversation as resolved.
Outdated
});
}
}