Skip to content

Add install telemetry #13653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Karthik Nadig (karthiknadig) merged 5 commits into from
Aug 28, 2020
Merged

Add install telemetry #13653

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
caf4da6
Add extension install telemetry.
karthiknadig Aug 28, 2020
fb0e913
Add tests.
karthiknadig Aug 28, 2020
c02ab65
Fix typo
karthiknadig Aug 28, 2020
cd539c8
Fix tests.
karthiknadig Aug 28, 2020
51ccd82
Update comment to reflect what the installed actually does.
karthiknadig Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests.
  • Loading branch information
@karthiknadig
karthiknadig committed Aug 28, 2020
commit fb0e91370e5cc37bcee7860d5a4f548409e1c48b
28 changes: 28 additions & 0 deletions src/test/telemetry/extensionInstallTelemetery.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import * as sinon from 'sinon';
import { anyString, instance, mock, when } from 'ts-mockito';
import { FileSystem } from '../../client/common/platform/fileSystem';
import { IFileSystem } from '../../client/common/platform/types';
import * as Telemetry from '../../client/telemetry';
import { setExtensionInstallTelemetryProperties } from '../../client/telemetry/extensionInstallTelemetry';

suite('Extension Install Telemetry', () => {
let fs: IFileSystem;
let telemetryPropertyStub: sinon.SinonStub;
setup(() => {
fs = mock(FileSystem);
telemetryPropertyStub = sinon.stub(Telemetry, 'setSharedProperty');
});
teardown(() => {
telemetryPropertyStub.restore();
});
test('PythonCodingPack exists', async () => {
when(fs.fileExists(anyString())).thenResolve(true);
await setExtensionInstallTelemetryProperties(instance(fs));
telemetryPropertyStub.calledOnceWithExactly('installSource', 'pythonCodingPack');
});
test('PythonCodingPack does not exists', async () => {
when(fs.fileExists(anyString())).thenResolve(false);
await setExtensionInstallTelemetryProperties(instance(fs));
telemetryPropertyStub.calledOnceWithExactly('installSource', 'markerPlace');
Comment thread
karthiknadig marked this conversation as resolved.
Outdated
});
});