Skip to content

Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing #13554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kim-Adeline Miguel (kimadeline) merged 12 commits into from
Aug 24, 2020
Merged

Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing #13554

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
69951c6
Update vscode-tas-client
Aug 20, 2020
53f9169
Add experiment group enum
Aug 20, 2020
bb10e88
Add method to retrieve experiment values
Aug 20, 2020
8366ec3
Implementation + tests
Aug 20, 2020
17d1b82
News file
Aug 20, 2020
baa9186
Update wording of the news entry
Aug 20, 2020
f8a7937
Merge branch 'master' into 13535-prompt-tip-survey
Aug 20, 2020
9e034f2
Add telemetry
Aug 20, 2020
ca09ca8
More tests
Aug 20, 2020
1ec708b
No opting-in and out of this one
Aug 21, 2020
62e7bd4
Don't fetch value if opted out, add tests
Aug 21, 2020
f3b2e12
Address comments
Aug 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add method to retrieve experiment values
  • Loading branch information
Kim-Adeline Miguel
Kim-Adeline Miguel committed Aug 20, 2020
commit bb10e88975813a6eb412c86390094a56299592f3
10 changes: 10 additions & 0 deletions src/client/common/experiments/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ export class ExperimentService implements IExperimentService {
return this.experimentationService.isCachedFlightEnabled(experiment);
}

public async getExperimentValue<T extends boolean | number | string>(
experimentName: string
): Promise<T | undefined> {
if (!this.experimentationService) {
return;
}

return this.experimentationService.getTreatmentVariableAsync('vscode', experimentName);
}

private logExperiments() {
const experiments = this.globalState.get<{ features: string[] }>(EXP_MEMENTO_KEY, { features: [] });

Expand Down
1 change: 1 addition & 0 deletions src/client/common/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,7 @@ export interface IExperimentsManager {
export const IExperimentService = Symbol('IExperimentService');
export interface IExperimentService {
inExperiment(experimentName: string): Promise<boolean>;
getExperimentValue<T extends boolean | number | string>(experimentName: string): Promise<T | undefined>;
}

export type InterpreterConfigurationScope = { uri: Resource; configTarget: ConfigurationTarget };
Expand Down