Skip to content

Remove unwanted file from extension - #1344

Merged
Brett Cannon (brettcannon) merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue1343
Apr 9, 2018
Merged

Brett Cannon (brettcannon) merged 1 commit into
microsoft:masterfrom
DonJayamanne:issue1343

Conversation

@DonJayamanne

Copy link
Copy Markdown

Fixes #1343

This pull request:

  • Has a title summarizes what is changing
  • [N/A] Includes a news entry file (remember to thank yourself!)
  • [N/A] Has unit tests & code coverage is not adversely affected (within reason)
  • [N/A] Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • [N/A] Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov

codecov Bot commented Apr 8, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #1344 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
+ Coverage    71.1%   71.33%   +0.22%     
==========================================
  Files         269      269              
  Lines       12395    12395              
  Branches     2198     2198              
==========================================
+ Hits         8814     8842      +28     
+ Misses       3447     3417      -30     
- Partials      134      136       +2
Impacted Files Coverage Δ
src/client/debugger/PythonProcess.ts 47.91% <0%> (-1.67%) ⬇️
src/client/debugger/mainV2.ts 77.27% <0%> (+0.82%) ⬆️
src/client/linters/baseLinter.ts 91.66% <0%> (+4.16%) ⬆️
src/client/common/installer/productInstaller.ts 64.55% <0%> (+4.23%) ⬆️
src/client/common/application/applicationShell.ts 30.76% <0%> (+7.69%) ⬆️
src/client/common/logger.ts 73.33% <0%> (+20%) ⬆️
src/client/linters/errorHandlers/errorHandler.ts 100% <0%> (+22.22%) ⬆️
src/client/linters/errorHandlers/notInstalled.ts 94.44% <0%> (+61.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f42f0...3385696. Read the comment docs.

@brettcannon
Brett Cannon (brettcannon) merged commit 7cd3103 into microsoft:master Apr 9, 2018
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the issue1343 branch June 20, 2018 03:18
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unnecessary files from Extension output

2 participants