Skip to content

Add factory class to create the process service #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Don Jayamanne (DonJayamanne) merged 15 commits into from
May 8, 2018
Merged

Add factory class to create the process service #1342

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e26b541
factory to create the process service
DonJayamanne Apr 8, 2018
d1cefe4
:hammer: pass resource
DonJayamanne Apr 8, 2018
068e914
:memo: news entry
DonJayamanne Apr 8, 2018
2f37a91
remove process service
DonJayamanne Apr 8, 2018
07c18c9
:hammer: use factory to create the service
DonJayamanne Apr 8, 2018
3abc648
:bug: singleton
DonJayamanne Apr 8, 2018
1d91fac
:bug: fix registraion (oops)
DonJayamanne Apr 8, 2018
d03c075
Remove dependency on IProcessService
DonJayamanne May 8, 2018
e29a084
Fix linter errors
DonJayamanne May 8, 2018
80280a5
Fix linter errors
DonJayamanne May 8, 2018
8374dc7
Fix errors in tests
DonJayamanne May 8, 2018
2cf8861
Remove use of env provider service
DonJayamanne May 8, 2018
708edc2
Revert changes
DonJayamanne May 8, 2018
4b18ad5
Fix tests
DonJayamanne May 8, 2018
f383281
Fix merge issue
DonJayamanne May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove process service
  • Loading branch information
@DonJayamanne
DonJayamanne committed May 8, 2018
commit 2f37a9113f10a6d80590101cb2d4b22996a3c8c4
5 changes: 1 addition & 4 deletions src/client/common/process/proc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,15 @@
// tslint:disable:no-any

import { spawn } from 'child_process';
import { inject, injectable, optional } from 'inversify';
import { Observable } from 'rxjs/Observable';
import { Disposable } from 'vscode';
import { createDeferred } from '../helpers';
import { EnvironmentVariables } from '../variables/types';
import { DEFAULT_ENCODING } from './constants';
import { ExecutionResult, IBufferDecoder, IProcessService, ObservableExecutionResult, Output, SpawnOptions, StdErrError } from './types';

@injectable()
export class ProcessService implements IProcessService {
constructor(@inject(IBufferDecoder) private readonly decoder: IBufferDecoder,
@optional() private readonly env?: EnvironmentVariables) { }
constructor(private readonly decoder: IBufferDecoder, private readonly env?: EnvironmentVariables) { }
public execObservable(file: string, args: string[], options: SpawnOptions = {}): ObservableExecutionResult<string> {
const encoding = options.encoding = typeof options.encoding === 'string' && options.encoding.length > 0 ? options.encoding : DEFAULT_ENCODING;
delete options.encoding;
Expand Down
2 changes: 0 additions & 2 deletions src/client/common/process/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ export type ExecutionResult<T extends string | Buffer> = {
stderr?: T;
};

export const IProcessService = Symbol('IProcessService');

export interface IProcessService {
execObservable(file: string, args: string[], options?: SpawnOptions): ObservableExecutionResult<string>;
exec(file: string, args: string[], options?: SpawnOptions): Promise<ExecutionResult<string>>;
Expand Down