Skip to content

Add gather status bar and update survey link #13225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
David Kutugata (DavidKutu) merged 11 commits into from
Aug 5, 2020
Merged

Add gather status bar and update survey link #13225

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
890b7e6
add status bar
DavidKutu Jul 29, 2020
369fdea
Merge branch 'master' into david/gatherStatusBar
DavidKutu Jul 31, 2020
25ae4e3
add localization
DavidKutu Jul 31, 2020
6c5acf1
Added news file
DavidKutu Jul 31, 2020
bbc682c
add a 2 second timeout
DavidKutu Jul 31, 2020
03821b0
updated the gather survey link
DavidKutu Jul 31, 2020
4a88ac3
Change the gather icon while gathering
DavidKutu Aug 5, 2020
debd937
moved the gathering redux function to
DavidKutu Aug 5, 2020
e53bb62
move css to common.css
DavidKutu Aug 5, 2020
d648240
removed the status bar message
DavidKutu Aug 5, 2020
6e81619
changed noop import
DavidKutu Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a 2 second timeout
  • Loading branch information
@DavidKutu
DavidKutu committed Jul 31, 2020
commit bbc682cabc46efb4c0de27d32fa583160cd00b92
8 changes: 6 additions & 2 deletions src/client/datascience/gather/gatherListener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,16 @@ export class GatherListener implements IInteractiveWindowListener {
break;

case InteractiveWindowMessages.GatherCode:
this.statusBar.show();
setTimeout(() => {
this.statusBar.show();
}, 2000);

@rchiodo Rich Chiodo (rchiodo) Aug 5, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this 2000 a constant? Seems to be repeated at least once and might make it easier to understand why the 2 sec wait.

this.handleMessage(message, payload, this.doGather);
break;

case InteractiveWindowMessages.GatherCodeToScript:
this.statusBar.show();
setTimeout(() => {
this.statusBar.show();
}, 2000);
this.handleMessage(message, payload, this.doGatherToScript);
break;

Expand Down