Skip to content

Port hiding the gather button while a cell is executing to release #12984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
David Kutugata (DavidKutu) merged 1 commit into from
Jul 15, 2020
+2 −0
Merged

Port hiding the gather button while a cell is executing to release #12984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
hide the gather button while a cell is executing
  • Loading branch information
@DavidKutu
DavidKutu committed Jul 15, 2020
commit 29adcdc60707f3c2c05759a63e78ffd382502698
1 change: 1 addition & 0 deletions src/datascience-ui/history-react/interactiveCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ export class InteractiveCell extends React.Component<IInteractiveCellProps> {
onClick={gatherCode}
hidden={
this.props.cellVM.cell.state === CellState.error ||
this.props.cellVM.cell.state === CellState.executing ||
this.props.cellVM.cell.data.cell_type === 'markdown' ||
!this.props.settings.gatherIsInstalled
}
Expand Down
1 change: 1 addition & 0 deletions src/datascience-ui/native-editor/nativeCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,7 @@ export class NativeCell extends React.Component<INativeCellProps> {
this.props.cellVM.cell.data.execution_count === null ||
this.props.cellVM.hasBeenRun === null ||
this.props.cellVM.hasBeenRun === false ||
this.props.cellVM.cell.state === CellState.executing ||
this.isError() ||
this.isMarkdownCell() ||
!this.props.gatherIsInstalled;
Expand Down