Skip to content

Fix regressions in trusted notebooks #12902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joyce Er (joyceerhl) merged 4 commits into from
Jul 13, 2020
Merged

Fix regressions in trusted notebooks #12902

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
319f852
Handle trustAllNotebooks
joyceerhl Jul 11, 2020
2d6f903
Fix bug where after trusting, UI didn't update
joyceerhl Jul 11, 2020
d4c51a1
Minor refactor
joyceerhl Jul 11, 2020
3230238
Feedback from Don
joyceerhl Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix bug where after trusting, UI didn't update
  • Loading branch information
@joyceerhl
joyceerhl committed Jul 11, 2020
commit 2d6f903ce17976f393c4262bfad8ac6a6b2696a1
4 changes: 2 additions & 2 deletions src/client/datascience/interactive-ipynb/nativeEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ export class NativeEditor extends InteractiveBase implements INotebookEditor {

// Sign up for dirty events
model.changed(this.modelChanged.bind(this));
this.previouslyNotTrusted = model.isTrusted;
this.previouslyNotTrusted = !model.isTrusted;

@joyceerhl Joyce Er (joyceerhl) Jul 11, 2020

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that monitorChangesToTrust tells the UI to update when the user trusts a previously untrusted notebook

}

// tslint:disable-next-line: no-any
Expand Down Expand Up @@ -602,7 +602,7 @@ export class NativeEditor extends InteractiveBase implements INotebookEditor {
if (this.previouslyNotTrusted && this.model?.isTrusted) {
this.previouslyNotTrusted = false;
// Tell UI to update main state
this.postMessage(InteractiveWindowMessages.TrustNotebookComplete).ignoreErrors();
await this.postMessage(InteractiveWindowMessages.TrustNotebookComplete);
Comment thread
joyceerhl marked this conversation as resolved.
Resolved
}
}
private renameVariableExplorerHeights(name: string, updatedName: string) {
Expand Down