Skip to content

Add trust feature for VS Code Notebooks - #12818

Merged
Don Jayamanne (DonJayamanne) merged 12 commits into
microsoft:masterfrom
DonJayamanne:trustnb
Jul 10, 2020
Merged

Add trust feature for VS Code Notebooks#12818
Don Jayamanne (DonJayamanne) merged 12 commits into
microsoft:masterfrom
DonJayamanne:trustnb

Conversation

@DonJayamanne

@DonJayamanne Don Jayamanne (DonJayamanne) commented Jul 8, 2020 •
edited
Loading

Copy link
Copy Markdown

For #10496

  • Adds support for trusted notebooks

Please review after ignoring white space

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Jul 8, 2020
DonJayamanne
Don Jayamanne (DonJayamanne) commented Jul 8, 2020
View reviewed changes
Comment thread src/client/datascience/notebook/notebookTrustHandler.ts Outdated
DonJayamanne
Don Jayamanne (DonJayamanne) commented Jul 8, 2020
View reviewed changes
Comment thread src/client/datascience/interactive-ipynb/nativeEditor.ts
DonJayamanne
Don Jayamanne (DonJayamanne) commented Jul 8, 2020
View reviewed changes
Comment thread src/client/datascience/interactive-ipynb/nativeEditor.ts
rchiodo
Rich Chiodo (rchiodo) reviewed Jul 8, 2020
View reviewed changes
Comment thread src/client/datascience/notebook/notebookTrustHandler.ts Outdated
DonJayamanne
Don Jayamanne (DonJayamanne) commented Jul 9, 2020
View reviewed changes
Comment thread src/client/datascience/notebook/notebookTrustHandler.ts Outdated
@DonJayamanne
Don Jayamanne (DonJayamanne) force-pushed the trustnb branch 2 times, most recently from 786e29b to 984dde3 Compare July 9, 2020 20:52
@DonJayamanne
Don Jayamanne (DonJayamanne) marked this pull request as ready for review July 9, 2020 22:28
@DonJayamanne Don Jayamanne (DonJayamanne) changed the title Enable/disable notebook based on trust Add trust feature for VS Code Notebooks Jul 9, 2020
joyceerhl
Joyce Er (joyceerhl) reviewed Jul 9, 2020
View reviewed changes
Comment thread src/client/datascience/constants.ts
rchiodo
Rich Chiodo (rchiodo) approved these changes Jul 10, 2020
View reviewed changes

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sonarqubecloud

sonarqubecloud Bot commented Jul 10, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit aba1d20 into microsoft:master Jul 10, 2020
Don Jayamanne (DonJayamanne) added a commit that referenced this pull request Jul 10, 2020
@DonJayamanne
Add trust feature for VS Code Notebooks (#12818)
b1eb6f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IanMatthewHuff Ian Huff (IanMatthewHuff) IanMatthewHuff approved these changes
@rchiodo Rich Chiodo (rchiodo) rchiodo approved these changes
@greazer Jim Griesmer (greazer) Awaiting requested review from greazer
@techwithtim Tim Ruscica (techwithtim) Awaiting requested review from techwithtim
+2 more reviewers
@joyceerhl Joyce Er (joyceerhl) joyceerhl left review comments
@DavidKutu David Kutugata (DavidKutu) DavidKutu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DonJayamanne @IanMatthewHuff @rchiodo @DavidKutu @joyceerhl