Skip to content

Activate banner prompt for Pylance #12817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mikhail Arkhipov (MikhailArkhipov) merged 30 commits into from
Jul 22, 2020
Merged

Activate banner prompt for Pylance #12817

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
04e0b34
Fix path
May 6, 2020
9297d96
Merge branch 'master' of https://github.com/Microsoft/vscode-python
May 6, 2020
9f3d5ac
Merge branch 'master' of https://github.com/Microsoft/vscode-python
May 11, 2020
607bf98
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jun 1, 2020
e566214
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jun 11, 2020
4477900
Actually fix settings
Jun 18, 2020
d0d50de
Add news
Jun 18, 2020
03aa5f9
Add test
Jun 18, 2020
e4a032f
Format
Jun 18, 2020
27eeec7
Suppress 'jediEnabled' removal
Jun 18, 2020
89f432e
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jun 23, 2020
3ed655b
Drop survey first launch threshold
Jun 26, 2020
64ac38a
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jun 29, 2020
52a4325
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jun 30, 2020
67d7cb8
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jul 8, 2020
bbe5a7f
Remove LS experiments
Jul 8, 2020
f29f7d7
Frequency + tests
Jul 8, 2020
19ccc20
Fix test
Jul 8, 2020
4dec978
Update message to match spec
jakebailey Jul 15, 2020
a7fe6a8
Open workspace for extension rather than changing setting
jakebailey Jul 16, 2020
f7e631a
Fix localization string
jakebailey Jul 16, 2020
370d52b
Show banners asynchronously
jakebailey Jul 16, 2020
1396abd
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
Jul 20, 2020
2450fc7
Add experiments
Jul 20, 2020
0300726
Formatting
Jul 20, 2020
f0d528c
Typo
Jul 20, 2020
57de3f8
Put back verifyAll
Jul 20, 2020
b3c85fc
Remove obsolete experiments, add Pylance
Jul 21, 2020
1ca6b11
Suppress experiment if Pylance is installed
Jul 21, 2020
c1de88a
PR feedback
Jul 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting
  • Loading branch information
Mikhail Arkhipov
Mikhail Arkhipov committed Jul 20, 2020
commit 0300726b7e7df70ef653c23be498953699e06c7f
2 changes: 1 addition & 1 deletion src/test/testing/banners/proposeNewLanguageServerBanner.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ suite('Propose Pylance Banner', () => {
appShell = typemoq.Mock.ofType<IApplicationShell>();
});
testData.forEach((t) => {
test(`${t.inExperiment ? 'In' : 'Not in'} experiment and "python.languageServer": "${t.lsType}" should ${
test(`${t.inExperiment ? 'In' : 'Not in'} experiment and "python.languageServer": "${t.lsType}" should ${
t.shouldShowBanner ? 'show' : 'not show'
} banner`, async () => {
settings.setup((x) => x.languageServer).returns(() => t.lsType);
Expand Down