Skip to content

Include notebook renderers in extension #12793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Don Jayamanne (DonJayamanne) merged 4 commits into from
Jul 9, 2020
Merged

Include notebook renderers in extension #12793

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a968ca3
Include renderers
DonJayamanne Jul 7, 2020
b4af150
Oops
DonJayamanne Jul 7, 2020
e5f693d
Update settings
DonJayamanne Jul 9, 2020
55950bd
Fixes
DonJayamanne Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Oops
  • Loading branch information
@DonJayamanne
DonJayamanne committed Jul 9, 2020
commit b4af150e9d87746c59968d1264f8c05c1ac12fbb
3 changes: 2 additions & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ gulp.task('compile-viewers', async () => {
await buildWebPackForDevOrProduction('./build/webpack/webpack.datascience-ui-viewers.config.js');
});

gulp.task('compile-webviews', gulp.series('compile-ipywidgets', 'compile-notebooks', 'compile-viewers', 'compile-renderers'));
gulp.task('compile-webviews', gulp.series('compile-ipywidgets', 'compile-notebooks', 'compile-viewers'));

gulp.task(
'check-datascience-dependencies',
Expand Down Expand Up @@ -177,6 +177,7 @@ gulp.task('webpack', async () => {
await buildWebPackForDevOrProduction('./build/webpack/webpack.datascience-ui-notebooks.config.js', 'production');
await buildWebPackForDevOrProduction('./build/webpack/webpack.datascience-ui-viewers.config.js', 'production');
await buildWebPackForDevOrProduction('./build/webpack/webpack.extension.config.js', 'extension');
await buildWebPackForDevOrProduction('./build/webpack/webpack.datascience-ui-renderers.config.js', 'production');

@DonJayamanne Don Jayamanne (DonJayamanne) Jul 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipping renderers in extension.
This is a fallback until we get Renderers extension published.

});

gulp.task('updateBuildNumber', async () => {
Expand Down