Skip to content

Change CDN files to download locally #11286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich Chiodo (rchiodo) merged 13 commits into from
Apr 21, 2020
Merged

Change CDN files to download locally #11286

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
43000bb
Working downloader
rchiodo Apr 20, 2020
a14e77b
Tests passing
rchiodo Apr 21, 2020
50233e1
Add more tests
rchiodo Apr 21, 2020
06a1900
Add retry test
rchiodo Apr 21, 2020
9cba0f7
Fix build errors. Not sure why not happening locally.
rchiodo Apr 21, 2020
d69f320
Fix unit tests
rchiodo Apr 21, 2020
8423847
Fix azure ml on windows
rchiodo Apr 21, 2020
13773b6
Fix sonar error
rchiodo Apr 21, 2020
d45f863
Add some more descriptive comments
rchiodo Apr 21, 2020
12903f9
More comments
rchiodo Apr 21, 2020
83eb8dc
Merge remote-tracking branch 'origin/master' into rchiodo/cdn_local
rchiodo Apr 21, 2020
9c5c4a8
Refactor some code
rchiodo Apr 21, 2020
ccb5f62
Make sure to not use exists as we're downloading anyway
rchiodo Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/master' into rchiodo/cdn_local
  • Loading branch information
@rchiodo
rchiodo committed Apr 21, 2020
commit 83eb8dc55806697ad96d45eec6f984c3fc372f0f
18 changes: 1 addition & 17 deletions src/client/datascience/jupyter/jupyterSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,23 +127,7 @@ export class JupyterSession extends BaseJupyterSession {
throw new JupyterInvalidKernelError(kernel);
}

// This is just like doing a restart, kill the old session (and the old restart session), and start new ones
if (this.session) {
this.shutdownSession(this.session, this.statusHandler).ignoreErrors();
this.restartSessionPromise?.then((r) => this.shutdownSession(r, undefined)).ignoreErrors(); // NOSONAR
}

// Update our kernel spec
this.kernelSpec = kernel;

// Save the new session
this.session = newSession;

// Listen for session status changes
this.session?.statusChanged.connect(this.statusHandler); // NOSONAR

// Start the restart session promise too.
this.restartSessionPromise = this.createRestartSession(kernel, this.session);
return newSession;
}

protected async createRestartSession(
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.