Skip to content

Ensure save works after saving untitled notebooks #11190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Don Jayamanne (DonJayamanne) merged 2 commits into from
Apr 15, 2020
Merged

Ensure save works after saving untitled notebooks #11190

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2756aad
Ensure save works after saving untitled notebooks
DonJayamanne Apr 15, 2020
1e28a59
Remove old document
DonJayamanne Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove old document
  • Loading branch information
@DonJayamanne
DonJayamanne committed Apr 15, 2020
commit 1e28a597c9eedf67199eacf19739259a1c1351a5
1 change: 1 addition & 0 deletions src/client/datascience/interactive-ipynb/nativeEditorProviderOld.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export class NativeEditorProviderOld extends NativeEditorProvider {
const customDocument = this.customDocuments.get(resource.fsPath);
if (customDocument) {
await this.saveAs(customDocument, targetResource);
this.customDocuments.delete(resource.fsPath);
this.customDocuments.set(targetResource.fsPath, { ...customDocument, uri: targetResource });
}
}
Expand Down