Skip to content

Validate python when nb opened not on extension activates #11087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Don Jayamanne (DonJayamanne) merged 1 commit into from
Apr 10, 2020
Merged

Validate python when nb opened not on extension activates #11087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Validate python when nb opened not on ext activate
  • Loading branch information
@DonJayamanne
DonJayamanne committed Apr 10, 2020
commit 96c6d4f6ed6645928a91faa6c29e5584f55f1705
1 change: 1 addition & 0 deletions news/2 Fixes/10893.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Performa validation of interpreter only when a Notebook is opened instead of when extension activates.
6 changes: 4 additions & 2 deletions src/client/datascience/activation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,21 @@ export class Activation implements IExtensionSingleActivationService {
public async activate(): Promise<void> {
this.disposables.push(this.notebookEditorProvider.onDidOpenNotebookEditor(this.onDidOpenNotebookEditor, this));
this.disposables.push(this.jupyterInterpreterService.onDidChangeInterpreter(this.onDidChangeInterpreter, this));
// Warm up our selected interpreter for the extension
this.jupyterInterpreterService.setInitialInterpreter().ignoreErrors();
this.contextService.activate().ignoreErrors();
}

private onDidOpenNotebookEditor(_: INotebookEditor) {
this.notebookOpened = true;
this.PreWarmDaemonPool().ignoreErrors();
sendTelemetryEvent(Telemetry.OpenNotebookAll);
// Warm up our selected interpreter for the extension
this.jupyterInterpreterService.setInitialInterpreter().ignoreErrors();
}

private onDidChangeInterpreter() {
if (this.notebookOpened) {
// Warm up our selected interpreter for the extension
this.jupyterInterpreterService.setInitialInterpreter().ignoreErrors();
this.PreWarmDaemonPool().ignoreErrors();
}
}
Expand Down