Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
b260c2a
Add conda environments
rchiodo Mar 4, 2020
885f972
Reenable multiple interpreters
rchiodo Mar 4, 2020
d3f04f6
Change path for conda environments
rchiodo Mar 4, 2020
11c6097
Add pip requirements
rchiodo Mar 4, 2020
db60ded
Get multiple interpreters test to work
rchiodo Mar 4, 2020
fca098e
Partially working conda search
rchiodo Mar 5, 2020
ba0fc56
Get conda working locally
rchiodo Mar 5, 2020
d4f3fee
Make windows supported environments
rchiodo Mar 5, 2020
fb16261
Fix hygiene
rchiodo Mar 5, 2020
bfb4cec
Fix memory leak for daemons
rchiodo Mar 6, 2020
43cf4a1
Fix hang on conda
rchiodo Mar 6, 2020
8e11f39
Actually retry
rchiodo Mar 6, 2020
2573ea0
Two missing setting change updates
rchiodo Mar 6, 2020
c418e11
Rework the failure capture
rchiodo Mar 6, 2020
318b82c
Get rid of memory leak when session dies
rchiodo Mar 6, 2020
cd9112a
Make tests leak less memory
rchiodo Mar 6, 2020
fd76344
Hygiene problem
rchiodo Mar 6, 2020
a83acca
More potential cleanup
rchiodo Mar 6, 2020
be983b2
More changes to clean up memory as soon as possible
rchiodo Mar 9, 2020
39f5e4b
Dont auto start jupyter
rchiodo Mar 9, 2020
dcd6c0f
More leaks found and fixes for breaking tests
rchiodo Mar 9, 2020
21eab4b
Merge remote-tracking branch 'origin/master' into rchiodo/test_with_a…
rchiodo Mar 9, 2020
87fbdbb
Fix missing args when test is shutting down
rchiodo Mar 10, 2020
96b4395
Put back some of the functional requirements
rchiodo Mar 10, 2020
587bafc
Update tests to not use static
rchiodo Mar 10, 2020
94b75fd
Fix linter tests
rchiodo Mar 10, 2020
7712c47
More output for linter tests
rchiodo Mar 10, 2020
b9fc139
Linter only fails with other tests
rchiodo Mar 10, 2020
6f85ffb
Install linters in conda too
rchiodo Mar 10, 2020
130fc50
Make base also have dependencies as it's being picked up anyway
rchiodo Mar 10, 2020
48cc263
Add news entry
rchiodo Mar 11, 2020
bcdfdaf
Review feedback
rchiodo Mar 11, 2020
04d6caa
Fix unit tests and one of the functional tests
rchiodo Mar 11, 2020
1f03b7c
Functional tests and workspace tests at the same time fail
rchiodo Mar 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually retry
  • Loading branch information
rchiodo committed Mar 6, 2020
commit 8e11f39c99b7e70b69f38a6480b9772def72c333
9 changes: 0 additions & 9 deletions src/client/interpreter/activation/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,15 +160,6 @@ export class EnvironmentActivationService implements IEnvironmentActivationServi
}
}
}
result = await processService.shellExec(command, {
env,
shell: shellInfo.shell,
timeout: getEnvironmentTimeout,
maxBuffer: 1000 * 1000
});
if (result.stderr && result.stderr.length > 0) {
throw new Error(`StdErr from ShellExec, ${result.stderr}`);
}
const returnedEnv = this.parseEnvironmentOutput(result.stdout);

// Put back the PYTHONWARNINGS value
Expand Down