Skip to content

Jupyter autocompletion will only show up on empty lines, #10420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
David Kutugata (DavidKutu) merged 5 commits into from
Mar 10, 2020
Merged

Jupyter autocompletion will only show up on empty lines, #10420

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58ae8b3
Jupyter autocompletion will only show up on empty lines,
Mar 3, 2020
24e31f9
filter out magic commands instead of
Mar 4, 2020
c464532
moved the new code to a function and created tests
Mar 10, 2020
4ac30b5
removed pressCtrlSpace function
Mar 10, 2020
a6a1736
added comments
Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed pressCtrlSpace function
  • Loading branch information
David Kutugata
David Kutugata committed Mar 10, 2020
commit 4ac30b5fa8bbafadc50657c0e084302564f2fa44
6 changes: 3 additions & 3 deletions src/test/datascience/intellisense.functional.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { MonacoEditor } from '../../datascience-ui/react-common/monacoEditor';
import { noop } from '../core';
import { DataScienceIocContainer } from './dataScienceIocContainer';
import { getOrCreateInteractiveWindow, runMountedTest } from './interactiveWindowTestHelpers';
import { getInteractiveEditor, pressCtrlSpace, typeCode } from './testHelpers';
import { enterEditorKey, getInteractiveEditor, typeCode } from './testHelpers';

// tslint:disable:max-func-body-length trailing-comma no-any no-multiline-string
suite('DataScience Intellisense tests', () => {
Expand Down Expand Up @@ -252,7 +252,7 @@ suite('DataScience Intellisense tests', () => {
// Then enter some code. Don't submit, we're just testing that autocomplete appears
const suggestion = waitForSuggestion(wrapper);
typeCode(getInteractiveEditor(wrapper), 'print');
pressCtrlSpace(wrapper);
enterEditorKey(wrapper, { code: ' ', ctrlKey: true });
await suggestion.promise;
suggestion.disposable.dispose();
verifyIntellisenseNotVisible(wrapper, '%%bash');
Expand Down Expand Up @@ -280,7 +280,7 @@ suite('DataScience Intellisense tests', () => {
// Then enter some code. Don't submit, we're just testing that autocomplete appears
const suggestion = waitForSuggestion(wrapper);
typeCode(getInteractiveEditor(wrapper), ' ');
pressCtrlSpace(wrapper);
enterEditorKey(wrapper, { code: ' ', ctrlKey: true });
await suggestion.promise;
suggestion.disposable.dispose();
verifyIntellisenseVisible(wrapper, '%%bash');
Expand Down
11 changes: 0 additions & 11 deletions src/test/datascience/testHelpers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,17 +677,6 @@ export function typeCode(
return textArea;
}

export function pressCtrlSpace(editorControl: ReactWrapper<any, Readonly<{}>, React.Component> | undefined) {
const textArea = getTextArea(editorControl);
assert.ok(textArea!, 'Cannot find the textarea inside the monaco editor');
textArea!.focus();

const keyCode = ' ';
enterKey(textArea!, keyCode, false, true);

return textArea;
}

function getTextArea(
editorControl: ReactWrapper<any, Readonly<{}>, React.Component> | undefined
): HTMLTextAreaElement | null {
Expand Down