Skip to content

More logging for kernelspec problems #10132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich Chiodo (rchiodo) merged 5 commits into from
Feb 14, 2020
Merged

More logging for kernelspec problems #10132

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf24372
More logging for kernelspec problems
rchiodo Feb 14, 2020
7dae94f
Actually capture the exception on the new code
rchiodo Feb 14, 2020
0d1d23a
Not actually using output if first exception still there.
rchiodo Feb 14, 2020
c4fb9d6
Actually only return output on one of the expected calls.
rchiodo Feb 14, 2020
529429c
Fix nightly flake
rchiodo Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually capture the exception on the new code
  • Loading branch information
@rchiodo
rchiodo committed Feb 14, 2020
commit 7dae94f21c0ec0730e563fbc03cd4f79175ce2b4
4 changes: 2 additions & 2 deletions src/client/datascience/jupyter/interpreter/jupyterCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,10 @@ export class InterpreterJupyterKernelSpecCommand extends InterpreterJupyterComma
try {
if (args.join(' ').toLowerCase() === 'list --json') {
// Try getting kernels using python script, if that fails (even if there's output in stderr) rethrow original exception.
return this.getKernelSpecList(interpreter, options);
output = await this.getKernelSpecList(interpreter, options);
} else if (args.join(' ').toLowerCase() === '--version') {
// Try getting kernelspec version using python script, if that fails (even if there's output in stderr) rethrow original exception.
return this.getKernelSpecVersion(interpreter, options);
output = await this.getKernelSpecVersion(interpreter, options);
}
} catch (innerEx) {
traceError('Failed to get a list of the kernelspec using python script', innerEx);
Expand Down