Skip to content

Interactive Window input box tweaks #10029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ian Huff (IanMatthewHuff) merged 5 commits into from
Feb 10, 2020
Merged

Interactive Window input box tweaks #10029

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
421a361
working style fixes
IanMatthewHuff Feb 10, 2020
90194b6
working focus set, needs rename
IanMatthewHuff Feb 10, 2020
82f81cb
test + rename
IanMatthewHuff Feb 10, 2020
27d5fa4
pre-review changes
IanMatthewHuff Feb 10, 2020
7f9e1bb
also hide focus wrapper on cells
IanMatthewHuff Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
working style fixes
  • Loading branch information
@IanMatthewHuff
IanMatthewHuff committed Feb 10, 2020
commit 421a361861f4cad70428b0bc1c85b8da4ccc26f6
7 changes: 6 additions & 1 deletion src/datascience-ui/history-react/interactivePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export class InteractivePanel extends React.Component<IInteractivePanelProps> {
<section id="main-panel-variable" aria-label={getLocString('DataScience.collapseVariableExplorerLabel', 'Variables')}>
{this.renderVariablePanel(this.props.baseTheme)}
</section>
<main id="main-panel-content" onScroll={this.handleScroll}>
<main id="main-panel-content" onClick={this.contentPanelClick} onScroll={this.handleScroll}>
{this.renderContentPanel(this.props.baseTheme)}
</main>
<section id="main-panel-footer" aria-label={getLocString('DataScience.editSection', 'Input new cells here')}>
Expand All @@ -82,6 +82,11 @@ export class InteractivePanel extends React.Component<IInteractivePanelProps> {
);
}

private contentPanelClick = (event: React.MouseEvent<HTMLDivElement, MouseEvent>) => {
// tslint:disable-next-line:no-console
console.log('here');
};

private renderToolbarPanel() {
const variableExplorerTooltip = this.props.variableState.visible
? getLocString('DataScience.collapseVariableExplorerTooltip', 'Hide variables active in jupyter kernel')
Expand Down
13 changes: 12 additions & 1 deletion src/datascience-ui/interactive-common/common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ body, html {
display: block;
}

.edit-panel-colorized .cell-wrapper:focus {
outline-width: 0px;
}
.edit-panel .cell-wrapper:focus {
outline-width: 0px;
}

.cell-outer {
display:grid;
grid-template-columns: auto 1fr;
Expand Down Expand Up @@ -252,12 +259,16 @@ body, html {
.code-watermark {
position: absolute;
top: 3px;
left: 30px;
left: 3px;
z-index: 500;
font-style: italic;
color: var(--override-watermark-color, var(--vscode-panelTitle-inactiveForeground));
}

.code-watermark:focus {
outline-width: 0;
}

.collapse-input-svg-rotate {
transform: rotate(45deg);
transform-origin: 0% 100%;
Expand Down
2 changes: 1 addition & 1 deletion src/datascience-ui/interactive-common/contentPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class ContentPanel extends React.Component<IContentPanelProps> {

public render() {
return (
<div id="content-panel-div" ref={this.containerRef}>
<div id="content-panel-div" role="group" ref={this.containerRef}>
<div id="cell-table">
<div id="cell-table-body" role="list">
{this.renderCells()}
Expand Down