Skip to content

Polish stack view - #9000

Open
Alex Ross (alexr00) wants to merge 2 commits into
alexr00/cautious-marsupialfrom
alexr00/prime-boar
Open

Polish stack view#9000
Alex Ross (alexr00) wants to merge 2 commits into
alexr00/cautious-marsupialfrom
alexr00/prime-boar

Conversation

@alexr00

@alexr00 Alex Ross (alexr00) commented Oct 1, 2026

Copy link
Copy Markdown
Member

No description provided.

@alexr00 Alex Ross (alexr00) self-assigned this Oct 1, 2026
@alexr00
Alex Ross (alexr00) requested a balanced review from Copilot October 1, 2026 14:18
@alexr00
Alex Ross (alexr00) added this pull request to stack #8993 October 1, 2026 14:20
Copilot AI reviewed Oct 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused UI changes are consistent and adequately covered by tests.

Review effort: Balanced
Findings: None

What changed in this PR

Polishes stack status visuals and adjusts branch deletion layout for stacked pull requests.

Changes:

  • Adds position-aware stack readiness icons and colors.
  • Moves stacked branch deletion into a dedicated block.
  • Expands UI tests for icons and button placement.
File Description
webviews/​editorWebview/​test/​overview.test.tsx Tests stack icons and branch deletion placement.
webviews/​editorWebview/​index.css Styles closed states and stacked deletion layout.
webviews/​components/​pullRequestStack.tsx Selects refined readiness icons by state and position.
webviews/​components/​merge.tsx Marks stacked branch deletion containers.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@alexr00
Alex Ross (alexr00) removed this pull request from stack #8993 October 1, 2026 14:33
@alexr00
Alex Ross (alexr00) added this pull request to stack #9001 October 1, 2026 14:35
@alexr00
Alex Ross (alexr00) marked this pull request as ready for review October 1, 2026 14:35
Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:35
Copilot AI reviewed Oct 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused visual changes are consistent and adequately covered by tests.

Review effort: Balanced
Findings: None

Copilot AI balanced review requested due to automatic review settings October 1, 2026 14:44
Copilot AI reviewed Oct 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The closed-state icon becomes invisible in high-contrast themes.

Review effort: Balanced
Findings: None

Previously missed (1)

In code that hasn't changed since last review

Medium severity Add high-contrast foreground override for blocked icon

webviews/​editorWebview/​index.css:795

In high-contrast themes, pullRequests.closed defaults to editor.background (package.json:3904-3909). Because non-current readiness badges also use editor.background, this new blocked icon becomes invisible. Please give blocked the same high-contrast foreground override already applied to merged and draft states.

@alexr00
Alex Ross (alexr00) removed this pull request from stack #9001 October 2, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@roblourens roblourens roblourens approved these changes

Assignees

@alexr00 Alex Ross (alexr00)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexr00 @roblourens