Modern UI: Fix redundant tab action fading in connected editor tabs - #336871
Dmitriy Vasyura (dmitrivMS) merged 2 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused CSS correction matches existing reservation behavior and includes suitable regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns Modern UI connected-tab fading with reserved action spacing, preventing unnecessary filename fades.
Changes:
- Excludes connected tabs from action fade masks.
- Removes a redundant connected-tab override.
- Adds regression coverage.
| File | Description |
|---|---|
modernUI.contribution.test.ts |
Tests connected-tab fade behavior. |
tabs.css |
Skips fades when connected tabs reserve space. |
connectedEditorTabs.css |
Removes ineffective duplicate rule. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
The fade on active tabs was made transparent in #337126, so it no longer has a visible effect for active tabs. This change completely hides the fade's
|
Problem
In Modern UI with connected tabs,
workbench.editor.tabActionReserveSpacedoes not affect the actual reservation of tab action space, but it does affect the tab action fade behavior.As a result, hovered, unmodified, and unpinned editor tabs can still show a faded filename even when the filename is not overlapped by the tab action button.
workbench.editor.tabActionReserveSpace: true:workbench.editor.tabActionReserveSpace: false:Fix
This change aligns the tab action fade rules with the actual tab action reservation rules in
tabs.css. Connected tabs are now treated the same as tabs that reserve action space when deciding whether the label should fade.It also removes a redundant CSS rule in the connected editor tabs stylesheet. That rule was no longer effective because it was overridden by a more specific selector in the main tabs stylesheet.