Repository navigation
python3: libcrypt doesn't need to be a dependency of libpython - #28887
Conversation
|
@microsoft-github-policy-service agree company="Koordinates Limited" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/python3/portfile.cmake
Frank (FrankXie05)
added
the
category:port-bug
7815a26 to
00d266c
Compare
Fixed upstream in Python3.11 via python/cpython#89596 Backport here to Python3.10 so libpython doesn't have a needless system dependency on libcrypt (which is different on Linux between RH-based and Debian-based distros too).
00d266c to
a89b54e
Compare
until microsoft/vcpkg#28887 is merged
There was a problem hiding this comment.
You have modified or added at least one portfile where deprecated functions are used.
Details
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)
vcpkg_extract_source_archive_ex -> vcpkg_extract_source_archive
vcpkg_build_msbuild -> vcpkg_install_msbuild
vcpkg_copy_tool_dependencies -> vcpkg_copy_tools
vcpkg_apply_patches should be replaced by the PATCHES arguments to the "extract" helpers (e.g. vcpkg_from_github())
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}The following files are affected:
ports/python3/portfile.cmake
|
Frank (@FrankXie05) anything else I need to do here? |
|
Robert Coup (@rcoup) We need fix the CI baseline issue. :) |
|
Clicking on the artifacts in that list does nothing — is there some permission needed to see the logs?
Is there a way to re-run CI? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frank (FrankXie05)
added
info:needs-maintainer-attention
|
Thanks for the backport! |
What does your PR fix?
vcpkg's Python3
libpython3.10.socurrently depends on libcrypt (as a system dependency), but it doesn't need to - it uses no symbols from the library. libcrypt is different on Linux between RH-based and Debian-based distros too, which makes it annoying.This is fixed upstream in Python3.11. Backport the upstream change here.
Which triplets are supported/not supported? Have you updated the CI baseline?
all (x64-linux-dynamic)
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes