Skip to content

Add FunctionChoiceBehavior for OpenAI #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Milder Hernandez (milderhc) merged 15 commits into from
May 1, 2025
Merged

Add FunctionChoiceBehavior for OpenAI #310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
03bd7ed
Remove authorName from ChatMessageContent
Apr 28, 2025
d380bb5
Merge branch 'main' of https://github.com/microsoft/semantic-kernel-j…
Apr 29, 2025
9b821db
Add FunctionChoiceBehavior implementation
Apr 29, 2025
bc61886
return Collections.unmodifiableList(functions)
Apr 29, 2025
8cd72af
Fixes
Apr 29, 2025
a222ccb
Fix retry logic
Apr 29, 2025
3c39538
Add suggestions
Apr 30, 2025
66976a9
Avoid notify thread when auto-invoke is not active
Apr 30, 2025
cbb37c6
Add @Nullable annotations
May 1, 2025
b568818
Add additional constructor for ChatHistoryAgentThread
May 1, 2025
fd33c21
Merge pull request #1 from milderhc/completion-agent
milderhc May 1, 2025
81abcbe
Fix keys of execution settings
May 1, 2025
394367f
Apply format
May 1, 2025
c535e61
Small fix
May 1, 2025
730af6c
Add Github plugin to learn resources
May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes
  • Loading branch information
Milder Hernandez Cagua
Milder Hernandez Cagua committed Apr 29, 2025
commit 8cd72afadf25ca5ec31458707c0f42f78c0fdb4f
5 changes: 4 additions & 1 deletion ...a/com/microsoft/semantickernel/aiservices/openai/chatcompletion/OpenAIToolCallConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
import com.azure.ai.openai.models.ChatCompletionsToolDefinition;
import com.azure.ai.openai.models.ChatCompletionsToolSelection;
import com.microsoft.semantickernel.functionchoice.FunctionChoiceBehaviorOptions;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;

import javax.annotation.Nullable;
import java.util.Collections;
import java.util.List;

public class OpenAIToolCallConfig {
Expand All @@ -21,6 +23,7 @@ public class OpenAIToolCallConfig {
* @param autoInvoke Indicates whether to automatically invoke the tool.
* @param options Additional options for function choice behavior.
*/
@SuppressFBWarnings("EI_EXPOSE_REP2")
public OpenAIToolCallConfig(
List<ChatCompletionsToolDefinition> tools,
ChatCompletionsToolSelection toolChoice,
Expand All @@ -38,7 +41,7 @@ public OpenAIToolCallConfig(
* @return The list of tools.
*/
public List<ChatCompletionsToolDefinition> getTools() {
return tools;
return Collections.unmodifiableList(tools);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion ...api/src/main/java/com/microsoft/semantickernel/functionchoice/FunctionChoiceBehavior.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public abstract class FunctionChoiceBehavior {
protected final List<KernelFunction<?>> functions;
protected final FunctionChoiceBehaviorOptions options;

protected FunctionChoiceBehavior(List<KernelFunction<?>> functions,
protected FunctionChoiceBehavior(@Nullable List<KernelFunction<?>> functions,
@Nullable FunctionChoiceBehaviorOptions options) {
this.functions = functions != null ? Collections.unmodifiableList(functions) : null;
this.fullFunctionNames = new HashSet<>();
Expand Down