Repository navigation
.Net: fix(functions): preserve JSON converter errors - #14576
Open
King Star (jstar0) wants to merge 1 commit into
Open
King Star (jstar0) wants to merge 1 commit into
King Star (jstar0) wants to merge 1 commit into
Conversation
Avoid falling back to raw arguments when JSON deserialization fails, so custom converter validation details reach the caller. Quote plain string arguments only when they are not valid JSON. Fixes microsoft#14575.
Contributor
Author
|
Could a maintainer approve the initial pull_request workflow runs for this PR? GitHub currently marks dotnet-format, dotnet-build-and-test, Merge Gatekeeper, Spell Check, and Python Integration Tests as action_required, so hosted validation has not started. The focused .NET 10 tests and dotnet format checks passed locally. Thanks. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14575.
TryToDeserializeValue currently catches JsonException and falls back to the original argument, so converter validation messages are lost and reflection returns a generic type mismatch. Some connectors also provide a plain string without JSON quotes, preventing valid string-backed custom types from reaching their converter.
This is distinct from #14001, which supplies default serializer options but retains the exception fallback.
Validation