Repository navigation
chore: Update build system to flit_core - #155
Merged
Merged
Conversation
Thomas Kluyver (takluyver)
changed the title
Contributor
Author
|
👋 I'd be very grateful if someone could take a look, because this repo serves as a template for lots of novice users, and it's leading them to do something that's likely to break in the future. |
Daniel Ciborowski (dciborow)
self-requested a review
May 16, 2024 23:03
Daniel Ciborowski (dciborow)
approved these changes
May 16, 2024
Contributor
so sorry for the delay. (I dont get to do as much Python as I used to) |
Contributor
Author
|
Thanks Daniel Ciborowski (@dciborow)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm opening this pull request as part of a push to modernise how packages use Flit as a Python build backend.
Using
flit_coreas the backend in place offlitis recommended in the docs, and will make it faster for tools like pip & build to build your package from source, as it has fewer dependencies to install.Specifying an explicit version range (
>=2,<4) helps to ensure that your package can still be readily built from source despite changes in future major versions of Flit, because it will still use version 3.x. For instance, a future version is likely to drop support for the[tool.flit.metadata]table, in favour of the now-standardised[project]table for metadata. This is also in the docs, along with details of which versions support which features.Most users probably install your package from a pre-built 'wheel' on PyPI, so this changes won't affect them at all. But people who install from a git checkout, for instance, will benefit.