Skip to content

fix(test runner): resolve source maps in listFiles - #43069

Open
Dmitry Gozman (dgozman) wants to merge 1 commit into
microsoft:mainfrom
dgozman:fix-42364
Open

fix(test runner): resolve source maps in listFiles#43069
Dmitry Gozman (dgozman) wants to merge 1 commit into
microsoft:mainfrom
dgozman:fix-42364

Conversation

@dgozman

@dgozman Dmitry Gozman (dgozman) commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • TestRunner.listFiles() now reports original sources for .js test files with inline or external source maps, reusing sourceMapSources from loadUtils.ts.
  • Listed files match the locations reported by listTests() / runTests() and can be passed back as locations.

Fixes #42364

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 failed
❌ [default] › source-map.spec.ts:194 › should discover new tests @vscode-extension
❌ [default-reuse] › source-map.spec.ts:194 › should discover new tests @vscode-extension
❌ [default-trace] › source-map.spec.ts:194 › should discover new tests @vscode-extension

4 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52542 passed, 1270 skipped

Merge workflow run.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🔴 The VS Code Extension failure looks caused by this PR

source-map.spec.ts:194 times out in all three extension configurations at the source-mapped listFiles → listTests handoff that this PR changes. The VS Code Extension job passed on the PR's exact base SHA.

Details

Caused by this PR

  • [default/default-reuse/default-trace] › source-map.spec.ts:194 › should discover new tests — each configuration reaches the assertion that expanding the mapped tests/test.spec.ts entry sends listTests, then waits until the 30-second test timeout. This PR changes listFiles() from reporting the generated build/test.spec.js suite to reporting its original tests/test.spec.ts source, directly changing that discovery path. The VS Code Extension job on base SHA b630e71f passed, while all three variants fail on 0fe19ae8.

The four entries reported as flaky recovered on retry and are not real failures under the triage rubric.

Triaged by the Playwright bot - agent run

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

8937 passed, 1489 skipped

Merge workflow run.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: VS Code extension should support inline source maps during test discovery

1 participant

@dgozman