Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Review requested widget now is customizable #440

Merged
Felipe G (guimafelipe) merged 4 commits into from
Aug 28, 2024
Merged

Review requested widget now is customizable #440

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d54c2d
Injecting in reiew code version
Aug 28, 2024
fa47641
Injecting in template version
Aug 28, 2024
bfb2a48
Reverted change in UserWidget class
Aug 28, 2024
920107e
Better quality of code, no more hacks
Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reverted change in UserWidget class
  • Loading branch information
Felipe da Conceicao Guimaraes
Felipe da Conceicao Guimaraes committed Aug 28, 2024
commit bfb2a48ec0ac386c3d168b9571376f717ffe282e
37 changes: 16 additions & 21 deletions src/GitHubExtension/Widgets/GitHubUserWidget.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,33 +135,28 @@ public override void OnCustomizationRequested(WidgetCustomizationRequestedArgs c
base.OnCustomizationRequested(customizationRequestedArgs);
}

protected void SubmitAction(string data)
public override void OnActionInvoked(WidgetActionInvokedArgs actionInvokedArgs)
{
var dataObject = JsonNode.Parse(data);

if (dataObject == null)
if (actionInvokedArgs.Verb == "Submit")
{
return;
}
var data = actionInvokedArgs.Data;
var dataObject = JsonNode.Parse(data);

ShowCategory = EnumHelper.StringToSearchCategory(dataObject["showCategory"]?.GetValue<string>() ?? string.Empty);
DeveloperLoginId = dataObject["account"]?.GetValue<string>() ?? string.Empty;
UpdateTitle(dataObject);
if (dataObject == null)
{
return;
}

ConfigurationData = data;
ShowCategory = EnumHelper.StringToSearchCategory(dataObject["showCategory"]?.GetValue<string>() ?? string.Empty);
DeveloperLoginId = dataObject["account"]?.GetValue<string>() ?? string.Empty;
UpdateTitle(dataObject);

// If we got here during the customization flow, we need to LoadContentData again
// so we can show the loading page rather than stale data.
LoadContentData();
UpdateActivityState();
}
ConfigurationData = data;

public override void OnActionInvoked(WidgetActionInvokedArgs actionInvokedArgs)
{
if (actionInvokedArgs.Verb == "Submit")
{
var data = actionInvokedArgs.Data;
SubmitAction(data);
// If we got here during the customization flow, we need to LoadContentData again
// so we can show the loading page rather than stale data.
LoadContentData();
UpdateActivityState();
}
else
{
Expand Down