Skip to content

Python: fix(python): prevent duplicate MCP tool execution after ambiguous connection loss #9247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Suhas Aggarwal (suhasagg) wants to merge 3 commits into from
Closed

Python: fix(python): prevent duplicate MCP tool execution after ambiguous connection loss #9247

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c10b7ef
fix(python): prevent duplicate MCP tool execution after connection loss
suhasagg Oct 8, 2026
ef53ec3
test(python): cover MCP no-replay behavior and advisory tool hints
suhasagg Oct 10, 2026
ced5913
docs(python): clarify explicit MCP recovery in integration test
suhasagg Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs(python): clarify explicit MCP recovery in integration test
  • Loading branch information
@suhasagg
suhasagg committed Oct 10, 2026
commit ced5913cdfd1225f865601ef8a4e411f6063f686
8 changes: 4 additions & 4 deletions python/packages/core/tests/core/test_mcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3590,10 +3590,10 @@ async def test_mcp_connection_reset_integration():
"""Test that connection reset works correctly with a real MCP server.

This integration test verifies:
1. Initial connection and tool execution works
2. Simulating connection failure triggers automatic reconnection
3. Tool execution works after reconnection
4. Exit stack cleanup happens properly during reconnection
1. Initial connection and tool execution succeed
2. Ambiguous connection failure raises without replaying the tool call
3. Explicit reconnection allows a subsequent independent tool invocation
4. Session and exit stack are replaced during explicit reconnection
"""
url = os.environ.get("LOCAL_MCP_URL")

Expand Down
Loading