Repository navigation
Python: fix(core): stop losing multiline consolidated memories on reload - #9240
Draft
Yufeng He (he-yufeng) wants to merge 1 commit into
Draft
Yufeng He (he-yufeng) wants to merge 1 commit into
Yufeng He (he-yufeng) wants to merge 1 commit into
Conversation
The write path normalizes every memory through _normalize_memory_text before it reaches a record, but _consolidate_topic hands the LLM's memories strings to MemoryTopicRecord raw. A consolidated memory with a line break is written by to_markdown as a bullet whose continuation lands on a non-bullet line, and from_markdown only reads "- " bullets, so a fresh store silently returns just the first line while the raw file still shows the rest. MemoryTopicRecord now normalizes each memory at construction, keeping the existing drop-empty tolerance, so single-line memories are a record invariant and the markdown round-trip is stable no matter which path supplied the text. Verified with the full agent-framework-core suite: 8536 tests, 0 failures; ruff and pyright clean on the changed files. Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Yufeng He (he-yufeng)
deployed
to
github-app-auth
October 9, 2026 13:17 — with 
GitHub Actions
Active
GitHub Actions
Active
Yufeng He (he-yufeng)
deployed
to
github-app-auth
October 9, 2026 13:17 — with
GitHub Actions
Active
GitHub Actions
Active
agent-framework-automation
Bot
added
the
python
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused normalization fix addresses the reported data loss and is covered at both record and consolidation levels.
0 open findings
What changed in this PR
Normalizes memory text at record construction to prevent multiline consolidated memories from being truncated after Markdown reload.
Changes:
- Enforces single-line, deduplicated memory records.
- Adds unit and consolidation round-trip coverage for LF and CRLF content.
| File | Description |
|---|---|
python/packages/core/agent_framework/_harness/_memory.py |
Normalizes memories during record initialization. |
python/packages/core/tests/core/test_harness_memory.py |
Tests normalization and fresh-store reload behavior. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
3 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
consolidate_memoriesaccepts a valid JSON response whosememoriesarray contains a string with an ordinary line break and reports success, but a freshMemoryFileStorereads back only the first line:to_markdownwrites the break verbatim as a non-bullet line in the Memories section, andfrom_markdownonly reads-bullets, so the continuation silently disappears on reload while the raw file still shows it. The write path does not hit this because_merge_memorynormalizes every memory through_normalize_memory_textbefore it reaches the record.Description & Review Guide
MemoryTopicRecord.__init__now runs each memory through_normalize_memory_text, the same normalizer the write path uses, while keeping the existing drop-empty tolerance. Single-line memories become a record invariant, so the markdown round-trip is stable no matter which path supplied the text.write_memory: line breaks fold into spaces instead of truncating on the next read. The on-disk format is unchanged, and existing single-line records are byte-identical after a rewrite._consolidate_topic, so every current and future intake path inherits the invariant.Related Issue
Fixes #9228
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and the title prefix in sync automatically.