Skip to content

Python: feat(core): add max_duration_seconds bound to tool invocation loop #7772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eduard van Valkenburg (eavanvalkenburg) merged 12 commits into from
Sep 8, 2026
Merged

Python: feat(core): add max_duration_seconds bound to tool invocation loop #7772

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
05ce001
feat(core): add max_duration_seconds bound and stop_reason signal to …
karthik-0306 Aug 19, 2026
7483e81
fix(core): unify batch limit decision precedence and propagate stop_r…
karthik-0306 Aug 21, 2026
10bb055
test: add missing tests for duration bounds, batch limits, and sessio…
karthik-0306 Aug 21, 2026
475d45b
Fix _apply_batch_limit_decision limits bug and Phase 1 test execution
karthik-0306 Aug 22, 2026
feb0479
fix(core): preserve budget start_time across approval resumes, dedupe…
karthik-0306 Aug 22, 2026
4ca7664
Merge main into fix-issue-7587, resolve CHNAGELOG conflict
karthik-0306 Aug 26, 2026
1d0e149
chore: remove CHANGELOG entry, updated centrally on release per review
karthik-0306 Aug 26, 2026
909beab
chore: fix ruff formatting in test_function_invocation_logic.py (exac…
karthik-0306 Aug 31, 2026
5fecf7b
Merge remote-tracking branch 'upstream/main' into fix-issue-7587
karthik-0306 Aug 31, 2026
5916cd8
Merge remote-tracking branch 'upstream/main' into fix-issue-7587
karthik-0306 Sep 7, 2026
773e063
fix(core): remove _agent_framework_stop_reason signal, keep max_durat…
karthik-0306 Sep 7, 2026
6c481b0
fix(core): satisfy pre-commit and typing CI checks
karthik-0306 Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix ruff formatting in test_function_invocation_logic.py (exac… 
…t CI-pinned ruff 0.16.3)
  • Loading branch information
@karthik-0306
karthik-0306 committed Aug 31, 2026
commit 909beab68df9ab6e5cffc1052900b62b8561b9a7
21 changes: 8 additions & 13 deletions python/packages/core/tests/core/test_function_invocation_logic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6776,6 +6776,7 @@ def fake_perf_counter() -> float:
agent = Agent(client=chat_client_base, tools=[op], middleware=[middleware])

from unittest.mock import patch

with patch("agent_framework._tools.perf_counter", side_effect=fake_perf_counter):
# First run: getting the approval request. Time is 0.0, so duration is not exceeded.
first_response = await agent.run("Go", session=session)
Expand All @@ -6789,10 +6790,7 @@ def fake_perf_counter() -> float:
current_time[0] = 10.0

# Second run: user provides the approval response, but duration is exceeded.
resume_message = Message(
role="user",
contents=[approval_request.to_function_approval_response(approved=True)]
)
resume_message = Message(role="user", contents=[approval_request.to_function_approval_response(approved=True)])
response = await agent.run(resume_message, session=session)

# The tool should NOT have executed
Expand Down Expand Up @@ -6837,6 +6835,7 @@ def fake_perf_counter() -> float:
return res

from unittest.mock import patch

with patch("agent_framework._tools.perf_counter", side_effect=fake_perf_counter):
if streaming:
stream = agent.run("Go", stream=True)
Expand Down Expand Up @@ -6881,6 +6880,7 @@ def fake_perf_counter() -> float:
return res

from unittest.mock import patch

with patch("agent_framework._tools.perf_counter", side_effect=fake_perf_counter):
first_response = await agent.run("Go", session=session)
assert any(c.type == "function_approval_request" for c in first_response.messages[-1].contents)
Expand All @@ -6891,9 +6891,7 @@ def fake_perf_counter() -> float:
approval_request = next(
c for c in first_response.messages[-1].contents if c.type == "function_approval_request"
)
resume_message = Message(
role="user", contents=[approval_request.to_function_approval_response(approved=True)]
)
resume_message = Message(role="user", contents=[approval_request.to_function_approval_response(approved=True)])

await agent.run(resume_message, session=session)

Expand All @@ -6912,9 +6910,7 @@ def op() -> str:

chat_client_base.function_invocation_configuration["max_duration_seconds"] = 100.0 # type: ignore[attr-defined]
chat_client_base.run_responses = [ # type: ignore[attr-defined]
ChatResponse(
messages=[Message(role="assistant", contents=[Content.from_text("first")])], finish_reason="stop"
),
ChatResponse(messages=[Message(role="assistant", contents=[Content.from_text("first")])], finish_reason="stop"),
ChatResponse(
messages=[Message(role="assistant", contents=[Content.from_text("second")])], finish_reason="stop"
),
Expand Down Expand Up @@ -6951,6 +6947,7 @@ def op() -> str:
agent = Agent(client=chat_client_base, tools=[op], middleware=[middleware])

from unittest.mock import patch

with patch("agent_framework._tools.perf_counter", return_value=0.0):
stream = agent.run("Go", session=session, stream=True)

Expand All @@ -6964,9 +6961,7 @@ def op() -> str:
approval_request = next(
c for c in first_response.messages[-1].contents if c.type == "function_approval_request"
)
resume_message = Message(
role="user", contents=[approval_request.to_function_approval_response(approved=True)]
)
resume_message = Message(role="user", contents=[approval_request.to_function_approval_response(approved=True)])

stream2 = agent.run(resume_message, session=session, stream=True)
async for _ in stream2:
Expand Down