Skip to content

Python: Fix FoundryAgent inheriting OPENAI_CHAT_MODEL for agent-reference requests #7283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eduard van Valkenburg (eavanvalkenburg) merged 4 commits into from
Jul 30, 2026
Merged

Python: Fix FoundryAgent inheriting OPENAI_CHAT_MODEL for agent-reference requests #7283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
840af00
Python: Fix FoundryAgent inheriting OPENAI_CHAT_MODEL for agent-refer…
karthik-0306 Jul 23, 2026
b65ac55
Python: Fix FoundryAgent inheriting OPENAI_CHAT_MODEL for agent-refer…
karthik-0306 Jul 23, 2026
3015e7f
fix(foundry): update test typing annotations to pass mypy, pyrefly, a…
karthik-0306 Jul 23, 2026
d8a625b
Merge branch 'main' into foundry-agent-env-model-fix
eavanvalkenburg Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(foundry): update test typing annotations to pass mypy, pyrefly, a… 
…nd ty
  • Loading branch information
@karthik-0306
karthik-0306 committed Jul 24, 2026
commit 3015e7f420eb18b0a0ee7152d4adb43525745901
2 changes: 1 addition & 1 deletion python/packages/foundry/agent_framework_foundry/_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def __init__(
tokenizer=tokenizer,
additional_properties=additional_properties,
)
self.model = "" # Foundry agents resolve model server-side; ignore env vars (#7272)
self.model = "" # Foundry agents resolve model server-side; ignore env vars (issue #7272).

@override
def as_agent(
Expand Down
13 changes: 7 additions & 6 deletions python/packages/foundry/tests/foundry/test_foundry_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1735,7 +1735,7 @@ def test_agent_default_options_not_polluted_by_openai_chat_model(
project_client=mock_project,
agent_name="my-prompt-agent",
)
agent = Agent(client=client, instructions="test")
agent = Agent(client=cast(Any, client), instructions="test")

model_in_options = agent.default_options.get("model")
assert model_in_options != "gpt-4.1-from-env", (
Expand Down Expand Up @@ -1766,11 +1766,12 @@ def test_raw_foundry_agent_chat_client_rejects_model_keyword_arg() -> None:
mock_project = MagicMock()
mock_project.get_openai_client.return_value = MagicMock(spec=AsyncOpenAI)

cls = cast(Any, RawFoundryAgentChatClient)
with pytest.raises(TypeError, match="unexpected keyword argument"):
RawFoundryAgentChatClient(
cls(
project_client=mock_project,
agent_name="my-prompt-agent",
model="gpt-5.4", # type: ignore[call-arg]
model="gpt-5.4",
)


Expand All @@ -1788,9 +1789,9 @@ def test_explicit_model_in_agent_default_options_survives(
agent_name="my-prompt-agent",
)
agent = Agent(
client=client,
client=cast(Any, client),
instructions="test",
default_options={"model": "gpt-5.4"},
default_options=cast(Any, {"model": "gpt-5.4"}),
)

assert agent.default_options.get("model") == "gpt-5.4", (
Expand All @@ -1813,7 +1814,7 @@ def test_explicit_model_in_as_agent_default_options_survives(
)
agent = client.as_agent(
instructions="test",
default_options={"model": "gpt-5.4"},
default_options=cast(Any, {"model": "gpt-5.4"}),
)

assert agent.default_options.get("model") == "gpt-5.4", (
Expand Down
Loading