Skip to content

translate 2 playground files to ko, update 2 playgound files(ko) - #1156

Merged
github-actions[bot] merged 2 commits into
microsoft:v2from
ss-won:issue910/translate-ko
Oct 10, 2020
Merged

github-actions[bot] merged 2 commits into
microsoft:v2from
ss-won:issue910/translate-ko

Conversation

@ss-won

@ss-won Sowon Jung (ss-won) commented Sep 28, 2020 •

Copy link
Copy Markdown
Contributor

en:

번역 리뷰 요청합니다 : YeonJuan (@yeonjuan) Dan Jeong (@guyeol) Seohee Park (@dvlprsh)

ref #910


지난번 #1077 번역시 누락되었던 부분이랑 어색한 문장 재수정하여 함께 PR 진행하였습니다.
번역하기 애매한 용어들은 모두 그대로 표기하였으니 오역, 제안사항 잘 부탁드리겠습니다 :)

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by Kibeom Kwon (@bumkeyy) - if they write a comment saying "LGTM" then it will be merged.

@ss-won Sowon Jung (ss-won) changed the title translate two playground files to ko, update two playgound files(ko) translate 2 playground files to ko, update 2 playgound files(ko) Sep 28, 2020

@yeonjuan YeonJuan (yeonjuan) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sowon Jung (@ss-won) 고생하셨습니다 :)

@ss-won
Sowon Jung (ss-won) force-pushed the issue910/translate-ko branch 2 times, most recently from 66c59d2 to 345be9d Compare October 4, 2020 04:01

@bumkeyy Kibeom Kwon (bumkeyy) left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

번역 중간에 이상한 문자가 포함되어 있는데 한번 확인해주세요 :)

Sowon Jung (ss-won) and others added 2 commits October 7, 2020 01:37
- fix awkward sentences in Asnc Await.ts(ko)

- correct missing of translation in Optional Chaining(ko)

- reflect code review

Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
- first translation

- reflect code review

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
Co-authored-by: Kibeom Kwon <kgbum2222@gmail.com>
@ss-won

Copy link
Copy Markdown
Contributor Author

고생하셨습니다 👍

번역 중간에 이상한 문자가 포함되어 있는데 한번 확인해주세요 :)

  • 편집기에서 복사+붙여넣기 하다가 이상한 문자가 들어간 것 같네요ㅠㅠ 확인 감사합니다. 🙇🏻‍♀️
  • playground는 카테고리 고유 명칭이라 생각해서 그냥 적은건데, 한글로 적어도 괜찮아 보이네요ㅎㅎ.. 적용했습니다!
  • Async Await.ts, Optional Chaining.ts 가독성이 좀 떨어지는 것 같아서, 추가로 수정해봤습니다. 리뷰 부탁드릴게요!

@bumkeyy

Copy link
Copy Markdown
Contributor

LGTM

@github-actions
github-actions Bot merged commit dcb951a into microsoft:v2 Oct 10, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Merging because Kibeom Kwon (@bumkeyy) is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants