Skip to content

Skip resolving files directly inside node_modules #52809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nathan Shively-Sanders (sandersn) merged 12 commits into from
May 11, 2023
Merged

Skip resolving files directly inside node_modules #52809

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5f96e29
Skip resolving files directly inside node_modules
sandersn Feb 16, 2023
299c42b
In node_modules, skip modules that look like absolute URIs
sandersn Feb 16, 2023
b279732
lolcolons
sandersn Feb 16, 2023
b05b643
Add test + skip more
sandersn Feb 16, 2023
f311945
Merge branch 'main' into skip-resolving-ts-files-in-node_modules
sandersn Feb 17, 2023
6bf4384
accept missed baseline
sandersn Feb 17, 2023
dd92d45
Merge branch 'main' into skip-resolving-ts-files-in-node_modules
sandersn May 9, 2023
1f469d2
only skip resolving in ESM
sandersn May 10, 2023
586a892
Revert some unneeded test changes
sandersn May 10, 2023
d74fcfc
revert unit tests too
sandersn May 10, 2023
407c245
remove unused baselines
sandersn May 10, 2023
11faca6
Add test cases for nodenext+ESM module resolution
sandersn May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
accept missed baseline
  • Loading branch information
@sandersn
sandersn committed Feb 17, 2023
commit 6bf4384872351985866ade6fdd276ea8d888f973
32 changes: 4 additions & 28 deletions ...e/pathMappingBasedModuleResolution_rootImport_aliasWithRoot_differentRootTypes.trace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,13 +167,7 @@
"File '/root/src/bar.tsx' does not exist.",
"File '/root/src/bar.d.ts' does not exist.",
"Directory '/root/src/bar' does not exist, skipping all lookups in it.",
"Loading module 'file:///bar' from 'node_modules' folder, target file types: TypeScript, Declaration.",
"Directory '/root/node_modules' does not exist, skipping all lookups in it.",
"Skipping module 'file:///bar' that looks like an absolute URI.",
"Skipping module 'file:///bar' that looks like an absolute URI.",
"Directory '/node_modules' does not exist, skipping all lookups in it.",
"Skipping module 'file:///bar' that looks like an absolute URI.",
"Skipping module 'file:///bar' that looks like an absolute URI.",
"Skipping module 'file:///bar' that looks like an absolute URI, target file types: TypeScript, Declaration.",
"'baseUrl' option is set to '/root', using this value to resolve non-relative module name 'file:///bar'.",
"'paths' option is specified, looking for a pattern to match module name 'file:///bar'.",
"Module name 'file:///bar', matched pattern 'file:///*'.",
Expand Down Expand Up @@ -201,13 +195,7 @@
"File '/root/src/bar.tsx' does not exist.",
"File '/root/src/bar.d.ts' does not exist.",
"Directory '/root/src/bar' does not exist, skipping all lookups in it.",
"Loading module 'file://c:/bar' from 'node_modules' folder, target file types: TypeScript, Declaration.",
"Directory '/root/node_modules' does not exist, skipping all lookups in it.",
"Skipping module 'file://c:/bar' that looks like an absolute URI.",
"Skipping module 'file://c:/bar' that looks like an absolute URI.",
"Directory '/node_modules' does not exist, skipping all lookups in it.",
"Skipping module 'file://c:/bar' that looks like an absolute URI.",
"Skipping module 'file://c:/bar' that looks like an absolute URI.",
"Skipping module 'file://c:/bar' that looks like an absolute URI, target file types: TypeScript, Declaration.",
"'baseUrl' option is set to '/root', using this value to resolve non-relative module name 'file://c:/bar'.",
"'paths' option is specified, looking for a pattern to match module name 'file://c:/bar'.",
"Module name 'file://c:/bar', matched pattern 'file://c:/*'.",
Expand Down Expand Up @@ -235,13 +223,7 @@
"File '/root/src/bar.tsx' does not exist.",
"File '/root/src/bar.d.ts' does not exist.",
"Directory '/root/src/bar' does not exist, skipping all lookups in it.",
"Loading module 'file://server/bar' from 'node_modules' folder, target file types: TypeScript, Declaration.",
"Directory '/root/node_modules' does not exist, skipping all lookups in it.",
"Skipping module 'file://server/bar' that looks like an absolute URI.",
"Skipping module 'file://server/bar' that looks like an absolute URI.",
"Directory '/node_modules' does not exist, skipping all lookups in it.",
"Skipping module 'file://server/bar' that looks like an absolute URI.",
"Skipping module 'file://server/bar' that looks like an absolute URI.",
"Skipping module 'file://server/bar' that looks like an absolute URI, target file types: TypeScript, Declaration.",
"'baseUrl' option is set to '/root', using this value to resolve non-relative module name 'file://server/bar'.",
"'paths' option is specified, looking for a pattern to match module name 'file://server/bar'.",
"Module name 'file://server/bar', matched pattern 'file://server/*'.",
Expand Down Expand Up @@ -269,13 +251,7 @@
"File '/root/src/bar.tsx' does not exist.",
"File '/root/src/bar.d.ts' does not exist.",
"Directory '/root/src/bar' does not exist, skipping all lookups in it.",
"Loading module 'http://server/bar' from 'node_modules' folder, target file types: TypeScript, Declaration.",
"Directory '/root/node_modules' does not exist, skipping all lookups in it.",
"Skipping module 'http://server/bar' that looks like an absolute URI.",
"Skipping module 'http://server/bar' that looks like an absolute URI.",
"Directory '/node_modules' does not exist, skipping all lookups in it.",
"Skipping module 'http://server/bar' that looks like an absolute URI.",
"Skipping module 'http://server/bar' that looks like an absolute URI.",
"Skipping module 'http://server/bar' that looks like an absolute URI, target file types: TypeScript, Declaration.",
"'baseUrl' option is set to '/root', using this value to resolve non-relative module name 'http://server/bar'.",
"'paths' option is specified, looking for a pattern to match module name 'http://server/bar'.",
"Module name 'http://server/bar', matched pattern 'http://server/*'.",
Expand Down