Skip to content

Add verbatimModuleSyntax, deprecate importsNotUsedAsValues and preserveValueImports #52203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrew Branch (andrewbranch) merged 19 commits into from
Jan 20, 2023
Merged

Add verbatimModuleSyntax, deprecate importsNotUsedAsValues and preserveValueImports #52203

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5ebc606
Add flag and update diagnostic messages
andrewbranch Dec 7, 2022
c1de572
Finish updating error messages
andrewbranch Dec 8, 2022
cf5c284
Add tests for loosened isolatedModules script checks
andrewbranch Dec 8, 2022
a612746
Update emit, add test
andrewbranch Dec 8, 2022
7e8dc51
Add elision tests, restrictions for export=
andrewbranch Dec 9, 2022
2ebbb97
Start adding syntax restrictions
andrewbranch Dec 10, 2022
5095a7e
Finish(?) syntax restrictions
andrewbranch Dec 12, 2022
0095a8e
Update other references to compilerOptions.isolatedModules
andrewbranch Dec 12, 2022
c328062
Merge branch 'main' into feature/verbatimModuleSyntax
andrewbranch Dec 15, 2022
8816d0e
Merge branch 'main' into feature/verbatimModuleSyntax
andrewbranch Dec 15, 2022
915c780
Auto-imports for CJS files
andrewbranch Dec 16, 2022
7bbbe9e
Merge branch 'main' into feature/verbatimModuleSyntax
andrewbranch Jan 11, 2023
cde58e3
Ensure ESM imports are type-only when possible
andrewbranch Jan 11, 2023
2e0acb2
Update baselines after merge
andrewbranch Jan 11, 2023
626820c
Disable marking stuff referenced since it’s not needed
andrewbranch Jan 11, 2023
f15d610
Deprecate importsNotUsedAsValues and preserveValueImports
andrewbranch Jan 11, 2023
addcca8
Clean up redundancy errors
andrewbranch Jan 12, 2023
b72c5d0
Allow export modifier on uninstantiated namespaces in CJS, fix export…
andrewbranch Jan 19, 2023
5cae284
Merge branch 'main' into feature/verbatimModuleSyntax
andrewbranch Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into feature/verbatimModuleSyntax
  • Loading branch information
@andrewbranch
andrewbranch committed Dec 15, 2022
commit 8816d0ede0edf5a8f72dce55149adc198e4fe1db
16 changes: 14 additions & 2 deletions src/compiler/diagnosticMessages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4273,14 +4273,26 @@
"category": "Error",
"code": 5100
},
"Option '{0}' is redundant and cannot be specified with option '{1}'.": {
"Flag '{0}' is deprecated and will stop functioning in TypeScript {1}. Specify 'ignoreDeprecations: \"{2}\"' to silence this error.": {
"category": "Error",
"code": 5101
},
"Option 'verbatimModuleSyntax' cannot be used when 'module' is set to 'UMD', 'AMD', or 'System'.": {
"Flag '{0}' is deprecated. Please remove it from your configuration.": {
"category": "Error",
"code": 5102
},
"Invalid value for '--ignoreDeprecations'.": {
"category": "Error",
"code": 5103
},
"Option '{0}' is redundant and cannot be specified with option '{1}'.": {
"category": "Error",
"code": 5104
},
"Option 'verbatimModuleSyntax' cannot be used when 'module' is set to 'UMD', 'AMD', or 'System'.": {
"category": "Error",
"code": 5105
},

"Generates a sourcemap for each corresponding '.d.ts' file.": {
"category": "Message",
Expand Down
16 changes: 8 additions & 8 deletions tests/baselines/reference/verbatimModuleSyntaxCompat.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
error TS5095: Option 'preserveValueImports' can only be used when 'module' is set to 'es2015' or later.
error TS5101: Option 'importsNotUsedAsValues' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
error TS5101: Option 'isolatedModules' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
error TS5101: Option 'preserveValueImports' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
error TS5102: Option 'verbatimModuleSyntax' cannot be used when 'module' is set to 'UMD', 'AMD', or 'System'.
error TS5104: Option 'importsNotUsedAsValues' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
error TS5104: Option 'isolatedModules' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
error TS5104: Option 'preserveValueImports' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
error TS5105: Option 'verbatimModuleSyntax' cannot be used when 'module' is set to 'UMD', 'AMD', or 'System'.


!!! error TS5095: Option 'preserveValueImports' can only be used when 'module' is set to 'es2015' or later.
!!! error TS5101: Option 'importsNotUsedAsValues' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
!!! error TS5101: Option 'isolatedModules' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
!!! error TS5101: Option 'preserveValueImports' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
!!! error TS5102: Option 'verbatimModuleSyntax' cannot be used when 'module' is set to 'UMD', 'AMD', or 'System'.
!!! error TS5104: Option 'importsNotUsedAsValues' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
!!! error TS5104: Option 'isolatedModules' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
!!! error TS5104: Option 'preserveValueImports' is redundant and cannot be specified with option 'verbatimModuleSyntax'.
!!! error TS5105: Option 'verbatimModuleSyntax' cannot be used when 'module' is set to 'UMD', 'AMD', or 'System'.
==== tests/cases/conformance/externalModules/verbatimModuleSyntaxCompat.ts (0 errors) ====
export {};
You are viewing a condensed version of this merge commit. You can view the full changes here.