Repository navigation
Ignore the directories or files in node_modules starting with "." and any file or directory starting with ".git" even in the recursive directory watching logic - #30247
Merged
Conversation
…les starting with "." Fixes #30004
Wesley Wigham (weswigham)
approved these changes
Mar 7, 2019
| } | ||
|
|
||
| /*@internal*/ | ||
| export const ignoredPaths = ["/node_modules/.", "/.git"]; |
There was a problem hiding this comment.
Is there a reason we're special casing .git and not just ignoring all dotfolders?
Member
Author
There was a problem hiding this comment.
Not sure if anything starting with "." is too aggressive but we definitely have reports about ".git" and hence added that one. We can relax this further later if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30004 and #29782