Skip to content

Mark ASAN failures in libcxx #4272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 5 commits into from
Jan 9, 2024
Merged

Mark ASAN failures in libcxx #4272

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
beaef89
For some MSVC-specific failures, I forgot to mark both :0 (MSVC plain…
StephanTLavavej Dec 16, 2023
cf47a01
Mark x86-specific "AddressSanitizer: allocator is out of memory" issu…
StephanTLavavej Dec 16, 2023
c08aae5
Comment why 2 tests in mem.poly.allocator.mem are marked for :0 (MSVC…
StephanTLavavej Dec 16, 2023
819b827
Consistently comment when we're marking only :0 (MSVC) because :1 (AS…
StephanTLavavej Dec 16, 2023
36b7584
Enhance a comment to mention that :1 means ASAN.
StephanTLavavej Dec 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Consistently comment when we're marking only :0 (MSVC) because :1 (AS… 
…AN) doesn't run static analysis.
  • Loading branch information
@StephanTLavavej
StephanTLavavej committed Dec 16, 2023
commit 819b8276f4236fa9390941a85043b797ca4a355c
4 changes: 4 additions & 0 deletions tests/libcxx/expected_results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp:0 FAIL
std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp:1 FAIL

# VSO-1271673 "static analyzer doesn't know about short-circuiting"
# Note: The :1 (ASAN) configuration doesn't run static analysis.
std/algorithms/alg.sorting/alg.sort/partial.sort/partial_sort.pass.cpp:0 FAIL
std/algorithms/alg.sorting/alg.sort/partial.sort/partial_sort_comp.pass.cpp:0 FAIL

Expand Down Expand Up @@ -399,6 +400,7 @@ std/algorithms/robust_re_difference_type.compile.pass.cpp:1 FAIL

# DevCom-1638563 VSO-1457836: icky static analysis false positive
# Resolved wontfix, need to report again.
# Note: The :1 (ASAN) configuration doesn't run static analysis.
std/language.support/support.coroutines/end.to.end/go.pass.cpp:0 FAIL

# DevCom-1638496 VSO-1462745: C1XX doesn't properly reject int <=> unsigned
Expand Down Expand Up @@ -1145,6 +1147,7 @@ std/utilities/format/format.formatter/format.formatter.spec/formatter.unsigned_i

# Not analyzed. Apparent false positives from static analysis where it thinks that array indexing is out of bounds.
# warning C28020: The expression '0<=_Param_(1)&&_Param_(1)<=1-1' is not true at this call.
# Note: The :1 (ASAN) configuration doesn't run static analysis.
std/containers/views/mdspan/extents/ctor_default.pass.cpp:0 FAIL
std/containers/views/mdspan/extents/ctor_from_array.pass.cpp:0 FAIL
std/containers/views/mdspan/extents/ctor_from_integral.pass.cpp:0 FAIL
Expand All @@ -1164,6 +1167,7 @@ std/containers/views/mdspan/mdspan/ctor.dh_span.pass.cpp:0 FAIL

# Not analyzed. Apparent false positives from static analysis where it thinks `new (std::nothrow)` could return null, despite an assert().
# warning C28182: Dereferencing NULL pointer.
# Note: The :1 (ASAN) configuration doesn't run static analysis.
std/language.support/support.dynamic/new.delete/new.delete.array/new.size_align_nothrow.pass.cpp:0 FAIL
std/language.support/support.dynamic/new.delete/new.delete.array/new.size_nothrow.pass.cpp:0 FAIL

Expand Down