Skip to content

<sstream>: Don't swap basic_stringbufs in move assignment and allocator-extended construction #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 14 commits into from
Jan 24, 2024
Merged

<sstream>: Don't swap basic_stringbufs in move assignment and allocator-extended construction #4239

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
29340e5
Don't swap `basic_stringbuf` in move assignment...
frederick-vs-ja Dec 5, 2023
1d58403
Conditional compilation
frederick-vs-ja Dec 5, 2023
f17e9f8
Avoid double `exchange`
frederick-vs-ja Dec 6, 2023
0d24cf6
Avoid additional functions
frederick-vs-ja Dec 6, 2023
ee2592a
Missed parentheses
frederick-vs-ja Dec 6, 2023
931310e
Fix bad self move assignment
frederick-vs-ja Dec 7, 2023
838d0bb
Merge remote-tracking branch 'origin/main' into basic_stringbuf-move
frederick-vs-ja Dec 16, 2023
3f5a327
Unblock one libcxx test
frederick-vs-ja Dec 16, 2023
8db8f64
Merge branch 'main' into basic_stringbuf-move
StephanTLavavej Jan 24, 2024
45fd402
`<memory_resource>` is C++17.
StephanTLavavej Jan 24, 2024
2d51a1a
Style: Exchange `_Seekhigh` before `_Mystate`.
StephanTLavavej Jan 24, 2024
98fcc22
Bugfix: Initialize `_Seekhigh`.
StephanTLavavej Jan 24, 2024
bada8fa
Bugfix: Use `_Pocma()`, which we want even when `is_always_equal`.
StephanTLavavej Jan 24, 2024
f1c6d4c
Simplify: `_Mybase::swap` always returns `void`.
StephanTLavavej Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid double exchange
  • Loading branch information
@frederick-vs-ja
frederick-vs-ja authored Dec 6, 2023
commit f17e9f814379003bc4056ac1a27d21cb3d340575
2 changes: 1 addition & 1 deletion stl/inc/sstream
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public:
basic_stringbuf(basic_stringbuf&& _Right)
: _Seekhigh(_STD exchange(_Right._Seekhigh, nullptr)), _Mystate(_STD exchange(_Right._Mystate, 0)),
_Al(_Right._Al) {
_Take_contents(_STD move(_Right));
_Mysb::swap(_Right);
}

basic_stringbuf& operator=(basic_stringbuf&& _Right) noexcept(
Expand Down