Skip to content

Don't warn when using operator<=> with 0 #3581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 6 commits into from
Mar 24, 2023
Merged

Don't warn when using operator<=> with 0 #3581

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3459b51
Don't warn when using operator<=> with 0
fsb4000 Mar 19, 2023
af5ee47
cannnot use _STL_VERIFY
fsb4000 Mar 19, 2023
cdba572
remove extra `_`
fsb4000 Mar 19, 2023
a40d721
Code review suggestions
fsb4000 Mar 21, 2023
e31e48b
Drop unnecessary forward declarations.
StephanTLavavej Mar 22, 2023
cc9f434
Use `GH-` for citation.
StephanTLavavej Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions stl/inc/compare
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,25 @@ _STL_DISABLE_CLANG_WARNINGS
#undef new

_STD_BEGIN
using _Literal_zero = decltype(nullptr);
using _Compare_t = signed char;
struct partial_ordering;
struct weak_ordering;
struct strong_ordering;
Comment thread
fsb4000 marked this conversation as resolved.
Resolved

void _Literal_zero_is_expected();

struct _Literal_zero {

Comment thread
fsb4000 marked this conversation as resolved.
Resolved
consteval _Literal_zero(int _Zero) noexcept {
// Can't use _STL_VERIFY because this is a core header
if (_Zero != 0) {
_Literal_zero_is_expected();
}
}

template <class _Ty, class = enable_if_t<!_Is_any_of_v<_Ty, int, partial_ordering, weak_ordering, strong_ordering>>>
Comment thread
fsb4000 marked this conversation as resolved.
Resolved
Comment thread
fsb4000 marked this conversation as resolved.
Resolved
_Literal_zero(_Ty) = delete;
};
using _Compare_t = signed char;
Comment thread
fsb4000 marked this conversation as resolved.
Resolved

// These "pretty" enumerator names are safe since they reuse names of user-facing entities.
enum class _Compare_eq : _Compare_t { equal = 0, equivalent = equal };
Expand Down
4 changes: 4 additions & 0 deletions tests/std/tests/P0768R1_spaceship_operator/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
#include <compare>
#include <type_traits>

#ifdef __clang__
#pragma clang diagnostic error "-Wzero-as-null-pointer-constant"
#endif // __clang__
Comment thread
fsb4000 marked this conversation as resolved.
Resolved

enum class comp { equal, less, greater, unordered };

template <comp Z, class T>
Expand Down